You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/09 09:22:21 UTC

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14390: [Feature](remote)Remote Storage support single file when Cooldown.(FE)

github-actions[bot] commented on code in PR #14390:
URL: https://github.com/apache/doris/pull/14390#discussion_r1064422343


##########
be/src/runtime/exec_env.cpp:
##########
@@ -18,10 +18,13 @@
 #include "runtime/exec_env.h"
 
 #include "gen_cpp/HeartbeatService_types.h"
+#include "util/time.h"
 
 namespace doris {
 
-ExecEnv::ExecEnv() : _is_init(false) {}
+ExecEnv::ExecEnv() : _is_init(false) {
+    _be_start_time_sec = GetCurrentTimeMicros() / 1000000;

Review Comment:
   warning: use of undeclared identifier '_be_start_time_sec' [clang-diagnostic-error]
   ```cpp
       _be_start_time_sec = GetCurrentTimeMicros() / 1000000;
       ^
   ```
   



##########
be/src/runtime/exec_env.h:
##########
@@ -184,6 +184,8 @@ class ExecEnv {
     HeartbeatFlags* heartbeat_flags() { return _heartbeat_flags; }
     doris::vectorized::ScannerScheduler* scanner_scheduler() { return _scanner_scheduler; }
 
+    int64_t be_start_time_sec() { return _be_start_time_sec; }

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   
   ```suggestion
       int64_t be_start_time_sec() { return _be_start_time_sec(); }
   ```
   



##########
be/src/runtime/exec_env.h:
##########
@@ -184,6 +184,8 @@
     HeartbeatFlags* heartbeat_flags() { return _heartbeat_flags; }
     doris::vectorized::ScannerScheduler* scanner_scheduler() { return _scanner_scheduler; }
 
+    int64_t be_start_time_sec() { return _be_start_time_sec; }

Review Comment:
   warning: use of undeclared identifier '_be_start_time_sec'; did you mean 'be_start_time_sec'? [clang-diagnostic-error]
   
   ```suggestion
       int64_t be_start_time_sec() { return be_start_time_sec; }
   ```
   **be/src/runtime/exec_env.h:186:** 'be_start_time_sec' declared here
   ```cpp
       int64_t be_start_time_sec() { return _be_start_time_sec; }
               ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org