You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/12 19:52:00 UTC
[jira] [Commented] (KAFKA-9855) dont waste memory allocating Struct
and values objects for Schemas with no fields
[ https://issues.apache.org/jira/browse/KAFKA-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081902#comment-17081902 ]
ASF GitHub Bot commented on KAFKA-9855:
---------------------------------------
radai-rosenblatt commented on pull request #8472: KAFKA-9855 - return cached Structs for Schemas with no fields
URL: https://github.com/apache/kafka/pull/8472
Signed-off-by: radai-rosenblatt <ra...@gmail.com>
at the time of this writing there are 6 schemas in kafka APIs with no fields - 3 versions each of LIST_GROUPS and API_VERSIONS.
when reading instances of these schemas off the wire there's little point in returning a unique Struct object (or a unique values array inside that Struct) since there is no payload.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> dont waste memory allocating Struct and values objects for Schemas with no fields
> ---------------------------------------------------------------------------------
>
> Key: KAFKA-9855
> URL: https://issues.apache.org/jira/browse/KAFKA-9855
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.4.0, 2.4.1
> Reporter: radai rosenblatt
> Assignee: radai rosenblatt
> Priority: Major
>
> at the time of this writing there are 6 schemas in kafka APIs with no fields - 3 versions each of LIST_GROUPS and API_VERSIONS.
> under some workloads this may result in the creation of a lot of Struct objects with an Object[0] for values when deserializing those requests from the wire.
> in one particular heap dump we've found a significant amount of heap space wasted on creating such objects.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)