[jira] [Commented] (CB-12341) Possible crash in [CDVUserAgentUtil releaseLock:]

["Shazron Abdullah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816445#comment-15816445 ] 

Shazron Abdullah commented on CB-12341:
---------------------------------------

Thanks for the report! 

Even though the NSInteger* is a pointer to a static type (and not an object) and can never be nil (nil is just "(id)0" thus is essentially NULL equivalent) the check should be there in either case.

> Possible crash in [CDVUserAgentUtil releaseLock:]
> -------------------------------------------------
>
>                 Key: CB-12341
>                 URL: https://issues.apache.org/jira/browse/CB-12341
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 3.5.0
>         Environment: only tested on iOS 10.x, but would affect other versions also.
>            Reporter: Ben Rigas
>            Assignee: Shazron Abdullah
>            Priority: Minor
>
> There is a possibility of a crash when calling [CDVUserAgentUtil releaseLock:] with a nil pointer. The first check in this method dereferences the lockToken pointer without first checking that it is non-nil, it should be updated to check for nil before continuing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org