You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/01 19:57:44 UTC

[GitHub] [beam] je-ik edited a comment on pull request #15082: [BEAM-12538] Allow PipelineOptions to be specified on command line of ExpansionService

je-ik edited a comment on pull request #15082:
URL: https://github.com/apache/beam/pull/15082#issuecomment-872511163


   > Why would annotations be safer?
   
   That might be only opinion-based. But creating new `ExternalServiceOptions` means you have two places to add an option when you want it to be respected by both runners and external services - you will not add an option to ExternalServiceOptions _only_. That is only a projection, not a complete domain. That is why I think, that selection is better done with annotations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org