[GitHub] [flink] wangyang0918 commented on a change in pull request #16086: [FLINK-22585] Add deprecated message when -m yarn-cluster is used

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #16086:
URL: https://github.com/apache/flink/pull/16086#discussion_r686652950



##########
File path: flink-python/src/main/java/org/apache/flink/client/python/PythonShellParser.java
##########
@@ -238,7 +249,9 @@ private static void constructYarnOption(
      * @param args Python shell yarn options.
      * @return Yarn options usrd in `flink run`.
      */
+    @Deprecated
     static List<String> parseYarn(String[] args) {
+        printYarnWarnMessage();

Review comment:
       For python users, we do not directly expose the `-m yarn-cluster` mode to users. So I think we do not need to introduce such changes in this PR.
   
   Instead, we could create a follow-up ticket to completely replace the `PythonShellParser#parseYarn` with new unified executor interface. Users should not be aware of this change. WDYT?

##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
##########
@@ -561,6 +561,8 @@ public int run(String[] args) throws CliArgsException, FlinkException {
         //
         //	Command Line Options
         //
+        LOG.warn("Cli: -m yarn-cluster is going to be depcreated. Please use unified executor "

Review comment:
       I am afraid we could not add the warning deprecated message here. Because only when we start a Flink per-job cluster or submit a Flink job to existing session cluster, this message should show up. So maybe putting the message in `AbstractYarnCli#isActive` is more appropriate.
   
   Moreover, if the user execute the `flink run -h`, it would be great to also show the deprecated message there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org