You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/08 02:52:14 UTC
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11755: feat: Sqllab to Explore UX improvements
graceguo-supercat commented on a change in pull request #11755:
URL: https://github.com/apache/incubator-superset/pull/11755#discussion_r537993483
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -124,6 +205,145 @@ export default class ResultSet extends React.PureComponent<
}
}
+ handleOnChangeAutoComplete = () => {
+ this.setState({ datasetToOverwrite: {} });
+ };
+
+ handleOverwriteDataset = async () => {
Review comment:
`async/await` usually used as a pair, to avoid nested `callback hells`. Could you please replace `.then` block with await?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org