You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/04/01 19:37:55 UTC

[GitHub] couchdb-fauxton pull request: sidebar: fix collapsible for special...

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/353

    sidebar: fix collapsible for special chars

    fix collapsible for design docs with special chars in their name,
    like `_design////design//foo` or `_design/bar.foo.bar`
    
    internally sizzle works with `querySelectorAll` which needs
    escaping for special chars in css selectors.
    
    based on a patch from Michelle Phung <mi...@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb-fauxton sidebar-escape

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #353
    
----
commit 9b94f8beed70aff0a97d6bbc1ebfb226d44a1050
Author: Robert Kowalski <ro...@apache.org>
Date:   2015-04-01T17:29:42Z

    sidebar: fix collapsible for special chars
    
    fix collapsible for design docs with special chars in their name,
    like `_design////design//foo` or `_design/bar.foo.bar`
    
    internally sizzle works with `querySelectorAll` which needs
    escaping for special chars in css selectors.
    
    based on a patch from Michelle Phung <mi...@gmail.com>

commit 3242541225335ace2fc401a90a16991c2b897de0
Author: Robert Kowalski <ro...@apache.org>
Date:   2015-04-01T17:32:28Z

    add CSS.escape polyfill
    
    src:
    https://github.com/mathiasbynens/CSS.escape/blob/af7f61a35ba23befe757c4f875a06c9d57c7ce29/css.escape.js

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: sidebar: fix collapsible for special...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/353


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: sidebar: fix collapsible for special...

Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/353#issuecomment-88576353
  
    +1 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: sidebar: fix collapsible for special...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/353#issuecomment-92321597
  
    merged as fb8387ea6119d4ed7d409d6935098bb0eaacc899 and 8260f0854e90ca3594b166d3cfb08e80a1a76ac3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---