You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/11/14 18:34:07 UTC
[GitHub] storm pull request #2420: [STORM-2814] Logviewer HTTP server should return 4...
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2420
[STORM-2814] Logviewer HTTP server should return 403 instead of 200 if the user is unauthorized
A trivial fix. Change the return HTTP Code from 200 to 403.
Also fixed the typos
https://issues.apache.org/jira/browse/STORM-2814
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ethanlm/storm STORM-2814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2420.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2420
----
commit 804dcebddfa5ac2ca4b0fb7bae1c6d6593dffe8d
Author: Ethan Li <et...@gmail.com>
Date: 2017-11-14T18:31:58Z
[STORM-2814] Logviewer HTTP server should return 403 instead of 200 if the user is unauthorized
----
---
[GitHub] storm pull request #2420: [STORM-2814] Logviewer HTTP server should return 4...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2420
---
[GitHub] storm issue #2420: [STORM-2814] Logviewer HTTP server should return 403 inst...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2420
Last commit changed other place from using 401 to 403 so that we can have a consistent http code for AuthorizedExceptions.
---
[GitHub] storm issue #2420: [STORM-2814] Logviewer HTTP server should return 403 inst...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2420
Forgot to +1 here. +1
---