You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@asterixdb.apache.org by Heri Ramampiaro <he...@gmail.com> on 2015/09/16 21:07:10 UTC

Webui template

FYI, I discovered today after I updated my local master with the Gerrit-master that parts of the 
“header” of the UI-template was missing, leaving just a “mess” when trying to load the
page @ http://127.0.0.1:19001 <http://127.0.0.1:19001/>. 

More specifically, the following lines were missing from asterix-app/src/main/resources/webui/querytemplate.html:

“
<!DOCTYPE html>
<html lang="en">
<head>
    <meta name="description" content="ASTERIX WEB PAGE" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <link href='http://fonts.googleapis.com/css?family=Bitter|PT+Sans+Caption|Open+Sans' rel='stylesheet' type='text/css'>
    <script src="/webui/static/js/jquery.min.js"></script>

    <link href="/webui/static/css/bootstrap.min.css" rel="stylesheet" type="text/css" />
    <link href="/webui/static/css/bootstrap-responsive.min.css" rel="stylesheet" type="text/css" />

    <script src="/webui/static/js/bootstrap.min.js"></script>

    <link href="/webui/static/css/style.css" rel="stylesheet" type="text/css" />

    <script type="text/javascript">
$(document).ready(function() {

    var optionButtonSize = $('#checkboxes-on').width();
    $('#clear-query-button, #run-btn').width(optionButtonSize);

    $('#checkboxes-on').click(function() {
        /* Displays a checkmark to indicate selection/clearing */
“

I think this happened when the file got new license statement header(?).

-heri




Re: Webui template

Posted by Ian Maxon <im...@uci.edu>.
Just to update, the fix for this is rolled into this change:
https://asterix-gerrit.ics.uci.edu/#/c/390/1

-Ian

On Wed, Sep 16, 2015 at 2:30 PM, Yingyi Bu <bu...@gmail.com> wrote:
> I think we can write a HTTP request to test that.
> I don't think currently we have any tests for the ui.
>
> Best,
> Yingyi
>
> On Wed, Sep 16, 2015 at 2:24 PM, Till Westmann <ti...@apache.org> wrote:
>
>> Is there an easy way to write a test for this?
>> Do we have other tests for the web ui?
>>
>> Cheers,
>> Till
>>
>>
>> On 16 Sep 2015, at 14:22, Ian Maxon wrote:
>>
>> Ah, yes I was fearing this might've happened. It was such a huge
>>> change that it's hard to pick out things like this. I'll fix this
>>> today. Thanks for catching this, Heri!
>>>
>>> -Ian
>>>
>>> On Wed, Sep 16, 2015 at 12:07 PM, Heri Ramampiaro <he...@gmail.com>
>>> wrote:
>>>
>>>> FYI, I discovered today after I updated my local master with the
>>>> Gerrit-master that parts of the
>>>> “header” of the UI-template was missing, leaving just a “mess” when
>>>> trying to load the
>>>> page @ http://127.0.0.1:19001 <http://127.0.0.1:19001/>.
>>>>
>>>> More specifically, the following lines were missing from
>>>> asterix-app/src/main/resources/webui/querytemplate.html:
>>>>
>>>> “
>>>> <!DOCTYPE html>
>>>> <html lang="en">
>>>> <head>
>>>>  <meta name="description" content="ASTERIX WEB PAGE" />
>>>>  <meta name="viewport" content="width=device-width, initial-scale=1.0">
>>>>  <link href='
>>>> http://fonts.googleapis.com/css?family=Bitter|PT+Sans+Caption|Open+Sans
>>>> <http://fonts.googleapis.com/css?family=Bitter%7CPT+Sans+Caption%7COpen+Sans>'
>>>> rel='stylesheet' type='text/css'>
>>>>  <script src="/webui/static/js/jquery.min.js"></script>
>>>>
>>>>  <link href="/webui/static/css/bootstrap.min.css" rel="stylesheet"
>>>> type="text/css" />
>>>>  <link href="/webui/static/css/bootstrap-responsive.min.css"
>>>> rel="stylesheet" type="text/css" />
>>>>
>>>>  <script src="/webui/static/js/bootstrap.min.js"></script>
>>>>
>>>>  <link href="/webui/static/css/style.css" rel="stylesheet"
>>>> type="text/css" />
>>>>
>>>>  <script type="text/javascript">
>>>> $(document).ready(function() {
>>>>
>>>>  var optionButtonSize = $('#checkboxes-on').width();
>>>>  $('#clear-query-button, #run-btn').width(optionButtonSize);
>>>>
>>>>  $('#checkboxes-on').click(function() {
>>>>      /* Displays a checkmark to indicate selection/clearing */
>>>> “
>>>>
>>>> I think this happened when the file got new license statement header(?).
>>>>
>>>> -heri
>>>>
>>>>
>>>>
>>>>

Re: Webui template

Posted by Yingyi Bu <bu...@gmail.com>.
I think we can write a HTTP request to test that.
I don't think currently we have any tests for the ui.

Best,
Yingyi

On Wed, Sep 16, 2015 at 2:24 PM, Till Westmann <ti...@apache.org> wrote:

> Is there an easy way to write a test for this?
> Do we have other tests for the web ui?
>
> Cheers,
> Till
>
>
> On 16 Sep 2015, at 14:22, Ian Maxon wrote:
>
> Ah, yes I was fearing this might've happened. It was such a huge
>> change that it's hard to pick out things like this. I'll fix this
>> today. Thanks for catching this, Heri!
>>
>> -Ian
>>
>> On Wed, Sep 16, 2015 at 12:07 PM, Heri Ramampiaro <he...@gmail.com>
>> wrote:
>>
>>> FYI, I discovered today after I updated my local master with the
>>> Gerrit-master that parts of the
>>> “header” of the UI-template was missing, leaving just a “mess” when
>>> trying to load the
>>> page @ http://127.0.0.1:19001 <http://127.0.0.1:19001/>.
>>>
>>> More specifically, the following lines were missing from
>>> asterix-app/src/main/resources/webui/querytemplate.html:
>>>
>>> “
>>> <!DOCTYPE html>
>>> <html lang="en">
>>> <head>
>>>  <meta name="description" content="ASTERIX WEB PAGE" />
>>>  <meta name="viewport" content="width=device-width, initial-scale=1.0">
>>>  <link href='
>>> http://fonts.googleapis.com/css?family=Bitter|PT+Sans+Caption|Open+Sans
>>> <http://fonts.googleapis.com/css?family=Bitter%7CPT+Sans+Caption%7COpen+Sans>'
>>> rel='stylesheet' type='text/css'>
>>>  <script src="/webui/static/js/jquery.min.js"></script>
>>>
>>>  <link href="/webui/static/css/bootstrap.min.css" rel="stylesheet"
>>> type="text/css" />
>>>  <link href="/webui/static/css/bootstrap-responsive.min.css"
>>> rel="stylesheet" type="text/css" />
>>>
>>>  <script src="/webui/static/js/bootstrap.min.js"></script>
>>>
>>>  <link href="/webui/static/css/style.css" rel="stylesheet"
>>> type="text/css" />
>>>
>>>  <script type="text/javascript">
>>> $(document).ready(function() {
>>>
>>>  var optionButtonSize = $('#checkboxes-on').width();
>>>  $('#clear-query-button, #run-btn').width(optionButtonSize);
>>>
>>>  $('#checkboxes-on').click(function() {
>>>      /* Displays a checkmark to indicate selection/clearing */
>>> “
>>>
>>> I think this happened when the file got new license statement header(?).
>>>
>>> -heri
>>>
>>>
>>>
>>>

Re: Webui template

Posted by Till Westmann <ti...@apache.org>.
Is there an easy way to write a test for this?
Do we have other tests for the web ui?

Cheers,
Till

On 16 Sep 2015, at 14:22, Ian Maxon wrote:

> Ah, yes I was fearing this might've happened. It was such a huge
> change that it's hard to pick out things like this. I'll fix this
> today. Thanks for catching this, Heri!
>
> -Ian
>
> On Wed, Sep 16, 2015 at 12:07 PM, Heri Ramampiaro <he...@gmail.com> 
> wrote:
>> FYI, I discovered today after I updated my local master with the 
>> Gerrit-master that parts of the
>> “header” of the UI-template was missing, leaving just a 
>> “mess” when trying to load the
>> page @ http://127.0.0.1:19001 <http://127.0.0.1:19001/>.
>>
>> More specifically, the following lines were missing from 
>> asterix-app/src/main/resources/webui/querytemplate.html:
>>
>> “
>> <!DOCTYPE html>
>> <html lang="en">
>> <head>
>>  <meta name="description" content="ASTERIX WEB PAGE" />
>>  <meta name="viewport" content="width=device-width, 
>> initial-scale=1.0">
>>  <link 
>> href='http://fonts.googleapis.com/css?family=Bitter|PT+Sans+Caption|Open+Sans' 
>> rel='stylesheet' type='text/css'>
>>  <script src="/webui/static/js/jquery.min.js"></script>
>>
>>  <link href="/webui/static/css/bootstrap.min.css" rel="stylesheet" 
>> type="text/css" />
>>  <link href="/webui/static/css/bootstrap-responsive.min.css" 
>> rel="stylesheet" type="text/css" />
>>
>>  <script src="/webui/static/js/bootstrap.min.js"></script>
>>
>>  <link href="/webui/static/css/style.css" rel="stylesheet" 
>> type="text/css" />
>>
>>  <script type="text/javascript">
>> $(document).ready(function() {
>>
>>  var optionButtonSize = $('#checkboxes-on').width();
>>  $('#clear-query-button, #run-btn').width(optionButtonSize);
>>
>>  $('#checkboxes-on').click(function() {
>>      /* Displays a checkmark to indicate selection/clearing */
>> “
>>
>> I think this happened when the file got new license statement 
>> header(?).
>>
>> -heri
>>
>>
>>

Re: Webui template

Posted by Ian Maxon <im...@uci.edu>.
Ah, yes I was fearing this might've happened. It was such a huge
change that it's hard to pick out things like this. I'll fix this
today. Thanks for catching this, Heri!

-Ian

On Wed, Sep 16, 2015 at 12:07 PM, Heri Ramampiaro <he...@gmail.com> wrote:
> FYI, I discovered today after I updated my local master with the Gerrit-master that parts of the
> “header” of the UI-template was missing, leaving just a “mess” when trying to load the
> page @ http://127.0.0.1:19001 <http://127.0.0.1:19001/>.
>
> More specifically, the following lines were missing from asterix-app/src/main/resources/webui/querytemplate.html:
>
> “
> <!DOCTYPE html>
> <html lang="en">
> <head>
>     <meta name="description" content="ASTERIX WEB PAGE" />
>     <meta name="viewport" content="width=device-width, initial-scale=1.0">
>     <link href='http://fonts.googleapis.com/css?family=Bitter|PT+Sans+Caption|Open+Sans' rel='stylesheet' type='text/css'>
>     <script src="/webui/static/js/jquery.min.js"></script>
>
>     <link href="/webui/static/css/bootstrap.min.css" rel="stylesheet" type="text/css" />
>     <link href="/webui/static/css/bootstrap-responsive.min.css" rel="stylesheet" type="text/css" />
>
>     <script src="/webui/static/js/bootstrap.min.js"></script>
>
>     <link href="/webui/static/css/style.css" rel="stylesheet" type="text/css" />
>
>     <script type="text/javascript">
> $(document).ready(function() {
>
>     var optionButtonSize = $('#checkboxes-on').width();
>     $('#clear-query-button, #run-btn').width(optionButtonSize);
>
>     $('#checkboxes-on').click(function() {
>         /* Displays a checkmark to indicate selection/clearing */
> “
>
> I think this happened when the file got new license statement header(?).
>
> -heri
>
>
>