You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/02/02 16:02:55 UTC
[GitHub] [maven] michael-o opened a new pull request #440: Remove ServiceLocator and Service
michael-o opened a new pull request #440:
URL: https://github.com/apache/maven/pull/440
@cstamas Here it it, yet incomplete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #440: Remove ServiceLocator and Service
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #440:
URL: https://github.com/apache/maven/pull/440#issuecomment-771755092
@cstamas Core ITs pass here locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet closed pull request #440: Remove ServiceLocator and Service
Posted by GitBox <gi...@apache.org>.
gnodet closed pull request #440:
URL: https://github.com/apache/maven/pull/440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #440: Remove ServiceLocator and Service
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #440:
URL: https://github.com/apache/maven/pull/440#issuecomment-771897898
Looks good, and we did overlap a bit :) I pushed (not created PR) for "update for 1.70, minimal changes" and "update post 1.7.0, ie. 2.0.0 when we want to drop locator"
https://github.com/apache/maven/compare/master...cstamas:for-170?expand=1
https://github.com/apache/maven/compare/master...cstamas:post-170?expand=1
For "post 1.7.0" IMO not only remove def ctor and init method, but injected things should be `final`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #440: Remove ServiceLocator and Service
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #440:
URL: https://github.com/apache/maven/pull/440#issuecomment-771957300
I think we can safely drop in Maven because this is a major anc the Resolver Provider is very Maven-specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #440: Remove ServiceLocator and Service
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #440:
URL: https://github.com/apache/maven/pull/440#issuecomment-771755092
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #440: Remove ServiceLocator and Service
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #440:
URL: https://github.com/apache/maven/pull/440#issuecomment-932728642
Closing as #547 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #440: Remove ServiceLocator and Service
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #440:
URL: https://github.com/apache/maven/pull/440#issuecomment-771897898
Looks good, and we did overlap a bit :) I pushed (not created PR) for "update for 1.70, minimal changes" and "update post 1.7.0, ie. 2.0.0 when we want to drop locator"
https://github.com/apache/maven/compare/master...cstamas:for-170?expand=1
https://github.com/apache/maven/compare/master...cstamas:post-170?expand=1
For "post 1.7.0" IMO not only remove def ctor and init method, but injected things should be `final`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org