[jira] [Comment Edited] (TEZ-1390) Replace byte[] with ByteBuffer as the type of user payload in the API

["Tsuyoshi OZAWA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095047#comment-14095047 ] 

Tsuyoshi OZAWA edited comment on TEZ-1390 at 8/13/14 2:38 AM:
--------------------------------------------------------------

Hi Sid, thanks for your comment. Yes, I agree with you and I'm planning to include following changes:

1. Changing UserPayload to accpets ByteBuffer and making getPayload return ByteBuffer.
2. Making constructors of user-facing classes accept ByteBuffer.

Internally, we can continue to work of the byte arrays.


was (Author: ozawa):
Hi Sid, thanks for your comment. Yes, I agree with you and I'm planning to include following changes:

1. Changing UserPayload to accpets ByteBuffer and making getPayload return ByteBuffer.
2. Making getUserPayload in all classes return ByteBuffer.
3. Making constructors of user-facing classes accept ByteBuffer.

Internally, we can continue to work of the byte arrays.

> Replace byte[] with ByteBuffer as the type of user payload in the API
> ---------------------------------------------------------------------
>
>                 Key: TEZ-1390
>                 URL: https://issues.apache.org/jira/browse/TEZ-1390
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Tsuyoshi OZAWA
>            Priority: Blocker
>
> This is just and API change. Internally we can continue to use byte[] since thats a much bigger change.
> The translation from ByteBuffer to byte[] in the API layer should not have perf impact.



--
This message was sent by Atlassian JIRA
(v6.2#6252)