You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "jrgemignani (via GitHub)" <gi...@apache.org> on 2023/05/12 21:24:11 UTC
[GitHub] [age] jrgemignani opened a new pull request, #916: Fix multiple label name usage in reused variables
jrgemignani opened a new pull request, #916:
URL: https://github.com/apache/age/pull/916
Fixed an issue with clauses and chained clauses reusing variables with different label names attached. Now they are disallowed.
Fixed the function prototypes make_vertex_expr and make_edge_expr as they were not using the passed char *label parameter.
Added regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] dehowef commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1548635357
> @dehowef @jrgemignani Just a small question here.`Labels that don't exist but do match` pass for edges but for vertices it fails. Should'nt that pass for vertices as well ?
>
> ```
> MATCH (r1:invalid), (r1:invalid) return 0
>
> ERROR: multiple labels for variable 'r1' are not supported
> LINE 2: MATCH (r1:invalid), (r1:invalid) return 0
> ^
> ```
it was probably overlooked, but yeah, I think the intended behavior is that it should fail for edges as well. Good looking out Taha. @jrgemignani, can you take a look when you have a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1550106245
@MuhammadTahaNaveed Does this crash exist outside of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] dehowef merged pull request #916: Fix multiple label name usage in reused variables
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef merged PR #916:
URL: https://github.com/apache/age/pull/916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] MuhammadTahaNaveed commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1553660472
> @MuhammadTahaNaveed @dehowef I have updated my PR to cover vertices and edges for label reuse. I have also corrected the crash. Please verify, though.
@jrgemignani Looks good. Great work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] MuhammadTahaNaveed commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1546997573
@dehowef @jrgemignani Just a small query here.`Labels that don't exist but do match` pass for edges but for vertices it fails. Should'nt that pass for vertices as well ?
```
MATCH (r1:invalid), (r1:invalid) return 0
ERROR: multiple labels for variable 'r1' are not supported
LINE 2: MATCH (r1:invalid), (r1:invalid) return 0
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] MuhammadTahaNaveed commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1550081439
> I'm not seeing a server termination -
@jrgemignani I just verified and there is a termination at my end. I am attaching the prior commands as well.
```
SELECT create_graph('label_issue');
```
```
SELECT * FROM cypher('label_issue', $$
CREATE (:related)
$$) AS (r0 agtype);
```
```
SELECT * FROM cypher('label_issue', $$
MATCH (n:relateds),(n:related) return 0
$$) AS (r0 agtype);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1549866154
I will fix the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] dehowef commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1546360288
Plethora of regression tests, removal of previously unused label field. Looks good to me. I'll wait for @MuhammadTahaNaveed 's review before further action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] dehowef commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1553717701
Looks good to me, I'll go ahead and merge it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1550015768
> @dehowef @jrgemignani Another issue I noticed later is the server termination caused by this query
>
> `MATCH (n:relateds),(n:related) return n`
>
I'm not seeing a server termination -
```
psql-11.5-5432-pgsql=# SELECT * FROM cypher('graph1', $$ MATCH (n:relateds),(n:related) return n $$) as (r agtype);
ERROR: multiple labels for variable 'n' are not supported
LINE 1: ...ECT * FROM cypher('graph1', $$ MATCH (n:relateds),(n:related...
^
psql-11.5-5432-pgsql=#
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] MuhammadTahaNaveed commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1548644568
@dehowef @jrgemignani Another issue I noticed later is the server termination caused by this query
```
MATCH (n:relateds),(n:related) return n
```
Here `relateds is an invalid label` and `related is a valid label`. This termination is most probably due to the missing condition `!cnode->label`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #916: Fix multiple label name usage in reused variables
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #916:
URL: https://github.com/apache/age/pull/916#issuecomment-1553630141
@MuhammadTahaNaveed @dehowef I have updated my PR to cover vertices and edges for label reuse. I have also corrected the crash. Please verify, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org