You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/09 02:35:27 UTC
[GitHub] [doris] qzsee opened a new pull request, #14955: [Peline](Operator) Add schema scan node operator
qzsee opened a new pull request, #14955:
URL: https://github.com/apache/doris/pull/14955
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14955: [Pipeline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #14955:
URL: https://github.com/apache/doris/pull/14955#discussion_r1044244829
##########
be/src/pipeline/exec/schema_scan_operator.cpp:
##########
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "schema_scan_operator.h"
+
+#include "vec/exec/vschema_scan_node.h"
+
+namespace doris::pipeline {
+
+OPERATOR_CODE_GENERATOR(SchemaScanOperator, Operator)
+
+Status SchemaScanOperator::open(RuntimeState* state) {
+ SCOPED_TIMER(_runtime_profile->total_time_counter());
+ return _node->open(state);
+}
+
+Status SchemaScanOperator::close(RuntimeState* state) {
+ RETURN_IF_ERROR(Operator::close(state));
+ _node->close(state);
Review Comment:
warning: 'close' is a private member of 'doris::vectorized::VSchemaScanNode' [clang-diagnostic-error]
```cpp
_node->close(state);
^
```
**be/src/vec/exec/vschema_scan_node.h:52:** declared private here
```cpp
Status close(RuntimeState* state) override;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Peline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1343802167
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Peline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1343911125
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Peline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1343919871
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Peline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1343767489
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14955: [Peline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1343823319
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.9 seconds
load time: 495 seconds
storage size: 17123356326 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221209041332_clickbench_pr_60696.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14955: [Pipeline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #14955:
URL: https://github.com/apache/doris/pull/14955#discussion_r1044243774
##########
be/src/pipeline/exec/schema_scan_operator.cpp:
##########
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "schema_scan_operator.h"
+
+#include "vec/exec/vschema_scan_node.h"
+
+namespace doris::pipeline {
+
+OPERATOR_CODE_GENERATOR(SchemaScanOperator, Operator)
+
+Status SchemaScanOperator::open(RuntimeState* state) {
+ SCOPED_TIMER(_runtime_profile->total_time_counter());
+ return _node->open(state);
+}
+
+Status SchemaScanOperator::close(RuntimeState* state) {
+ RETURN_IF_ERROR(Operator::close(state));
+ _node->close(state);
Review Comment:
warning: 'close' is a private member of 'doris::vectorized::VSchemaScanNode' [clang-diagnostic-error]
```cpp
_node->close(state);
^
```
**be/src/vec/exec/vschema_scan_node.h:53:** declared private here
```cpp
Status close(RuntimeState* state) override;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Pipeline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1344011261
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Pipeline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1344083923
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Peline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1343781135
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Peline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1343802153
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Pipeline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1344091225
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Pipeline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1344083259
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #14955: [Pipeline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #14955:
URL: https://github.com/apache/doris/pull/14955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14955: [Peline](Operator) Add schema scan node operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14955:
URL: https://github.com/apache/doris/pull/14955#issuecomment-1343916206
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org