[GitHub] [spark] shahidki31 commented on a change in pull request #26246: [SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page

[GitBox <gi...@apache.org>]

shahidki31 commented on a change in pull request #26246: [SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page
URL: https://github.com/apache/spark/pull/26246#discussion_r339059566
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
 ##########
 @@ -328,11 +320,12 @@ private[ui] class SqlStatsPagedTable(
       <td>
         {if (info.closeTimestamp > 0) formatDate(info.closeTimestamp)}
       </td>
+      <!-- Returns a human-readable string representing a duration such as "5 second 35 ms"-->
       <td >
-        {UIUtils.formatDuration(executionTime)}
+        {formatDurationVerbose(executionTime)}
 
 Review comment:
   Yes, but in thriftserver page, earlier it was `UIUtils.formatDurationVerbose`. For consistency, I think I added here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org