You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/05/17 21:47:57 UTC
Re: Review Request 34259: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/
-----------------------------------------------------------
(Updated May 17, 2015, 7:47 p.m.)
Review request for mesos and Cody Maloney.
Summary (updated)
-----------------
Replaced os::dirname and os::basename with Path::dirname and Path::basename.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 588bd3e
Diff: https://reviews.apache.org/r/34259/diff/
Testing
-------
make check on trailing RR.
Thanks,
Till Toenshoff
Re: Review Request 34259: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/#review84505
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On May 17, 2015, 9:47 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34259/
> -----------------------------------------------------------
>
> (Updated May 17, 2015, 9:47 p.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 588bd3e
>
> Diff: https://reviews.apache.org/r/34259/diff/
>
>
> Testing
> -------
>
> make check on trailing RR.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34259: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/#review88981
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:26 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34259/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 4:26 a.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp a67a3afdb30d23eb1b265b04ae662f64e874b6c6
>
> Diff: https://reviews.apache.org/r/34259/diff/
>
>
> Testing
> -------
>
> make check on trailing RR.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 34259: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/
-----------------------------------------------------------
(Updated June 23, 2015, 8:26 a.m.)
Review request for mesos and Cody Maloney.
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp a67a3afdb30d23eb1b265b04ae662f64e874b6c6
Diff: https://reviews.apache.org/r/34259/diff/
Testing
-------
make check on trailing RR.
Thanks,
Till Toenshoff
Re: Review Request 34259: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/
-----------------------------------------------------------
(Updated June 5, 2015, 1:22 p.m.)
Review request for mesos and Cody Maloney.
Changes
-------
rebased
Bugs: MESOS-1303
https://issues.apache.org/jira/browse/MESOS-1303
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp f1d3e5b
Diff: https://reviews.apache.org/r/34259/diff/
Testing
-------
make check on trailing RR.
Thanks,
Till Toenshoff
Re: Review Request 34259: Replaced os::dirname and os::basename with
Path::dirname and Path::basename.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/#review84379
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 17, 2015, 7:47 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34259/
> -----------------------------------------------------------
>
> (Updated May 17, 2015, 7:47 p.m.)
>
>
> Review request for mesos and Cody Maloney.
>
>
> Bugs: MESOS-1303
> https://issues.apache.org/jira/browse/MESOS-1303
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 588bd3e
>
> Diff: https://reviews.apache.org/r/34259/diff/
>
>
> Testing
> -------
>
> make check on trailing RR.
>
>
> Thanks,
>
> Till Toenshoff
>
>