You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Chunwei Lei (Jira)" <ji...@apache.org> on 2020/04/01 02:49:00 UTC

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

    [ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072320#comment-17072320 ] 

Chunwei Lei commented on CALCITE-3851:
--------------------------------------

I would like to merge this pr if there are no other comments.

> Replace the node importance map with a set for pruned nodes
> -----------------------------------------------------------
>
>                 Key: CALCITE-3851
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3851
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Liya Fan
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Currently, volcano planner stores rel node importances with a map. In fact, the value of the map can only be 0. 
> So there is no need to store the values, and we replace the map with a set to store nodes whose importances are 0. 
> This makes the code logic clearer, and avoids instability caused by comparing floating point values. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)