[GitHub] [airflow] zhongjiajie commented on a change in pull request #7575: [AIRFLOW-6949] Respect explicit `spark.kubernetes.namespace` conf to SparkSubmitOperator

[GitBox <gi...@apache.org>]

zhongjiajie commented on a change in pull request #7575: [AIRFLOW-6949] Respect explicit `spark.kubernetes.namespace` conf to SparkSubmitOperator
URL: https://github.com/apache/airflow/pull/7575#discussion_r385480964
 
 

 ##########
 File path: airflow/providers/apache/spark/hooks/spark_submit.py
 ##########
 @@ -208,6 +208,9 @@ def _resolve_connection(self):
                 self._conn_id, conn_data['master']
             )
 
+        if 'spark.kubernetes.namespace' in self._conf:
+            conn_data['namespace'] = self._conf['spark.kubernetes.namespace']
 
 Review comment:
   Maybe better change line 204, WDYT
   ```py
   conn_data['namespace'] = self._conf['spark.kubernetes.namespace'] if 'spark.kubernetes.namespace' in self._conf else extra.get('namespace')
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services