You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/04/05 06:33:33 UTC

[GitHub] svatoun commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

svatoun commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.
URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-378834220
 
 
   Apologies - I didn't clone your PR changes into a repository to view it in context, just reviewed a diff; I'll do better (hopefully today). 
   
   The SOE is because of unconditional recursive call at line 466. BTW I don't undertand the point of recursively calling the method - the while itself should be enough to iterate back through tokens. Maybe some leftover ? But the while _must_ check for either token == null or movePrevious() outcome to break the cycle at the start of token sequence and avoid NPE.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists