You are viewing a plain text version of this content. The canonical link for it is here.

Posted to user@thrift.apache.org by Andrew Pennebaker <ap...@42six.com> on 2013/08/21 17:07:48 UTC

Tweak to thrift.el for better compatibility

I'm working on copying thrift-mode to the MELPA repo so that developers can
still edit .thrift files on machines without Thrift installed. There
appears to be a few really minor discrepancies with thrift.el, easily
ammended, to make this possible.

Could we patch thrift thusly?

https://github.com/milkypostman/melpa/pull/973#issuecomment-22969265

Re: Tweak to thrift.el for better compatibility

Posted by Andrew Pennebaker <ap...@42six.com>.

Thanks for the heads up. I created an issue.
https://issues.apache.org/jira/browse/THRIFT-2142

I may not have time to write the patch myself, but I thought I'd at least
get the ball rolling.


On Wed, Aug 21, 2013 at 11:29 AM, Jake Farrell <jf...@apache.org> wrote:

> Hey Andrew
> If you could create a ticket in jira (
> https://issues.apache.org/jira/browse/THRIFT) and attach a patch for your
> changes would be happy to review and integrate into the codebase. More
> detailed information on the full process we follow is available on our
> website at
>
> http://thrift.apache.org/docs/HowToContribute/
>
> If you have any questions let me know and thanks for your contribution
> -Jake
>
>
>
> On Wed, Aug 21, 2013 at 11:07 AM, Andrew Pennebaker
> <ap...@42six.com>wrote:
>
> > I'm working on copying thrift-mode to the MELPA repo so that developers
> can
> > still edit .thrift files on machines without Thrift installed. There
> > appears to be a few really minor discrepancies with thrift.el, easily
> > ammended, to make this possible.
> >
> > Could we patch thrift thusly?
> >
> > https://github.com/milkypostman/melpa/pull/973#issuecomment-22969265
> >
>

Re: Tweak to thrift.el for better compatibility

Posted by Jake Farrell <jf...@apache.org>.

Hey Andrew
If you could create a ticket in jira (
https://issues.apache.org/jira/browse/THRIFT) and attach a patch for your
changes would be happy to review and integrate into the codebase. More
detailed information on the full process we follow is available on our
website at

http://thrift.apache.org/docs/HowToContribute/

If you have any questions let me know and thanks for your contribution
-Jake

On Wed, Aug 21, 2013 at 11:07 AM, Andrew Pennebaker
<ap...@42six.com>wrote:

> I'm working on copying thrift-mode to the MELPA repo so that developers can
> still edit .thrift files on machines without Thrift installed. There
> appears to be a few really minor discrepancies with thrift.el, easily
> ammended, to make this possible.
>
> Could we patch thrift thusly?
>
> https://github.com/milkypostman/melpa/pull/973#issuecomment-22969265
>