You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2015/12/12 10:52:51 UTC
Review Request 41302: MESOS-1718: add slave's configuration into
SlaveInfo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: add slave's configuration into SlaveInfo
Diffs
-----
include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41302/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41302: MESOS-1718: add slave's configuration into
SlaveInfo
Posted by Klaus Ma <kl...@gmail.com>.
> On Dec. 14, 2015, 9:53 p.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 511
> > <https://reviews.apache.org/r/41302/diff/1/?file=1161522#file1161522line511>
> >
> > Seems the executor_rootfs is not a slave configuraiton? I can only set launcher_dir, sandbox_dir and switch_user when starting slaves.
`executor_rootfs` is assign by a macro (`COMMAND_EXECUTOR_ROOTFS_CONTAINER_PATH`); considering it's a slave configuration.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/#review110230
-----------------------------------------------------------
On Dec. 12, 2015, 5:52 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41302/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 5:52 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: add slave's configuration into SlaveInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
> include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
>
> Diff: https://reviews.apache.org/r/41302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41302: MESOS-1718: add slave's configuration into
SlaveInfo
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/#review110230
-----------------------------------------------------------
include/mesos/mesos.proto (line 511)
<https://reviews.apache.org/r/41302/#comment170026>
Seems the executor_rootfs is not a slave configuraiton? I can only set launcher_dir, sandbox_dir and switch_user when starting slaves.
- Guangya Liu
On Dec. 12, 2015, 9:52 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41302/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 9:52 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: add slave's configuration into SlaveInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
> include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
>
> Diff: https://reviews.apache.org/r/41302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41302: MESOS-1718: add slave's configuration into
SlaveInfo.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 7:46 a.m.)
Review request for mesos, Ben Mahler, Ian Downes, Joseph Wu, and Vinod Kone.
Changes
-------
rebase
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: add slave's configuration into SlaveInfo
Diffs (updated)
-----
include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646
include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54
Diff: https://reviews.apache.org/r/41302/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41302: MESOS-1718: add slave's configuration into
SlaveInfo.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:56 a.m.)
Review request for mesos, Ben Mahler, Ian Downes, Joseph Wu, and Vinod Kone.
Changes
-------
rebase for apply conflict
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: add slave's configuration into SlaveInfo
Diffs (updated)
-----
include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b
include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd
Diff: https://reviews.apache.org/r/41302/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41302: MESOS-1718: add slave's configuration into
SlaveInfo.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/
-----------------------------------------------------------
(Updated Jan. 16, 2016, 1:46 p.m.)
Review request for mesos, Ben Mahler, Ian Downes, Joseph Wu, and Vinod Kone.
Changes
-------
Add period to the end of Summary.
Summary (updated)
-----------------
MESOS-1718: add slave's configuration into SlaveInfo.
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: add slave's configuration into SlaveInfo
Diffs
-----
include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd
include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c
Diff: https://reviews.apache.org/r/41302/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41302: MESOS-1718: add slave's configuration into
SlaveInfo
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 1:11 p.m.)
Review request for mesos, Ben Mahler, Ian Downes, Joseph Wu, and Vinod Kone.
Changes
-------
rebase
Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718
Repository: mesos
Description
-------
MESOS-1718: add slave's configuration into SlaveInfo
Diffs (updated)
-----
include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd
include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c
Diff: https://reviews.apache.org/r/41302/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41302: MESOS-1718: add slave's configuration into
SlaveInfo
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/#review110152
-----------------------------------------------------------
include/mesos/mesos.proto (lines 509 - 512)
<https://reviews.apache.org/r/41302/#comment169920>
It is better to add some comments to explain the meaning for each of the field as others.
- Guangya Liu
On 十二月 12, 2015, 9:52 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41302/
> -----------------------------------------------------------
>
> (Updated 十二月 12, 2015, 9:52 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-1718: add slave's configuration into SlaveInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
> include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
>
> Diff: https://reviews.apache.org/r/41302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>