You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/30 01:01:21 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37707: [SPARK-40257][PYTHON][DOCS] Remove since usage in `pyspark.sql.streaming.query`, and `pyspark.sql.window`

HyukjinKwon commented on code in PR #37707:
URL: https://github.com/apache/spark/pull/37707#discussion_r957910403


##########
python/pyspark/sql/streaming/query.py:
##########
@@ -127,11 +129,12 @@ def name(self) -> str:
         return self._jsq.name()
 
     @property  # type: ignore[misc]

Review Comment:
   ```suggestion
       @property
   ```



##########
python/pyspark/sql/streaming/query.py:
##########
@@ -73,12 +73,13 @@ def id(self) -> str:
         return self._jsq.id().toString()
 
     @property  # type: ignore[misc]

Review Comment:
   ```suggestion
       @property
   ```



##########
python/pyspark/sql/streaming/query.py:
##########
@@ -99,14 +100,15 @@ def runId(self) -> str:
         return self._jsq.runId().toString()
 
     @property  # type: ignore[misc]

Review Comment:
   ```suggestion
       @property
   ```



##########
python/pyspark/sql/streaming/query.py:
##########
@@ -44,7 +43,6 @@ def __init__(self, jsq: JavaObject) -> None:
         self._jsq = jsq
 
     @property  # type: ignore[misc]

Review Comment:
   ```suggestion
       @property
   ```



##########
python/pyspark/sql/streaming/query.py:
##########
@@ -219,13 +224,14 @@ def status(self) -> Dict[str, Any]:
         return json.loads(self._jsq.status().json())
 
     @property  # type: ignore[misc]

Review Comment:
   ```suggestion
       @property
   ```



##########
python/pyspark/sql/streaming/query.py:
##########
@@ -194,11 +198,12 @@ def awaitTermination(self, timeout: Optional[int] = None) -> Optional[bool]:
             return self._jsq.awaitTermination()
 
     @property  # type: ignore[misc]

Review Comment:
   ```suggestion
       @property
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org