You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/10/05 22:36:10 UTC

[GitHub] [incubator-pinot] snleee commented on pull request #6107: Making pushType non-mandatory

snleee commented on pull request #6107:
URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703925780


   If we want to remove the mandatory check, we should adjust codes to align all the usage with falling back to the default behavior. We can make `APPEND` as the default behavior since it's the most common use case. Currently, the code explicitly checks the `APPEND` in most cases, so `null` value for push type will end up with the `REFRESH` behavior. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org