[jira] [Commented] (ORC-407) JasonFileDump class needs to be updated to take into account string truncations

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622067#comment-16622067 ] 

ASF GitHub Bot commented on ORC-407:
------------------------------------

GitHub user moresandeep opened a pull request:

    https://github.com/apache/orc/pull/311

    ORC-407 - Lowerbound and upperbound support in JsonFileDump

    As part of this change JsonFileDump will now take into account lowerbound and upperbound values, specifically, if lowerbound or upperbound are set then lowerbound or upperbound are printed instead of min and max else min and max are printed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/moresandeep/orc ORC-407

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/311.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #311
    
----
commit 549c7ca8e40bc7ac224ab8677cffd183f410731e
Author: Sandeep More <mo...@...>
Date:   2018-09-20T13:40:48Z

    ORC-407 - Lowerbound and upperbound support in JsonFileDump

----


> JasonFileDump class needs to be updated to take into account string truncations
> -------------------------------------------------------------------------------
>
>                 Key: ORC-407
>                 URL: https://issues.apache.org/jira/browse/ORC-407
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Sandeep More
>            Assignee: Sandeep More
>            Priority: Major
>
> ORC-203 introduces a feature that trims long strings to 1024 characters and record the fact that they were trimmed by introducing lowerbound and upperbounds. 
> When string is truncated then lowerbound is set and getMinumum() will return null same for getMaxiumum().
> JasonFileDump class needs to be fixed to reflect these changes. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)