You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/01 12:49:40 UTC

[GitHub] [camel-k] nicolaferraro opened a new pull request #2476: Fix #2468: parse all YAML nodes in the tree

nicolaferraro opened a new pull request #2476:
URL: https://github.com/apache/camel-k/pull/2476


   <!-- Description -->
   
   Fix #2468
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] nicolaferraro merged pull request #2476: Fix #2468: parse all YAML nodes in the tree

Posted by GitBox <gi...@apache.org>.

nicolaferraro merged pull request #2476:
URL: https://github.com/apache/camel-k/pull/2476


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] nicolaferraro commented on pull request #2476: Fix #2468: parse all YAML nodes in the tree

Posted by GitBox <gi...@apache.org>.

nicolaferraro commented on pull request #2476:
URL: https://github.com/apache/camel-k/pull/2476#issuecomment-872273691


   > Trusting the unit test cases. Though I think it will need a cleaner refactoring. The way it is, it's difficult to understand what it does.
   
   Yeah, I wanted to fully rewrite it, but there are untested things that I don't fully understand, so I opted for maintaining the structure. The relevant part for the change is probably this part that digs into all the YAML tree to later find known keywords: https://github.com/apache/camel-k/pull/2476/files#diff-7e7c57f38d81ba22aab4b4a1ef3d536b46c9d2d9432cb215059c52d57e6090efR140-R154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org