You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 07:28:41 UTC
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#88: Licensing final fixes / touches for 2.0.0
tzulitai commented on a change in pull request #88: Licensing final fixes / touches for 2.0.0
URL: https://github.com/apache/flink-statefun/pull/88#discussion_r401408184
##########
File path: statefun-examples/statefun-ridesharing-example/statefun-ridesharing-example-simulator/pom.xml
##########
@@ -169,6 +178,24 @@ under the License.
<exclude>META-INF/*.RSA</exclude>
</excludes>
</filter>
+ <filter>
+ <artifact>org.apache.kafka:*</artifact>
+ <excludes>
+ <exclude>kafka/kafka-version.properties</exclude>
+ <exclude>LICENSE</exclude>
+ <!-- Does not contain anything relevant.
+ Cites a binary dependency on jersey, but this is neither reflected in the
+ dependency graph, nor are any jersey files bundled. -->
+ <exclude>NOTICE</exclude>
Review comment:
To address that we can manually merge it to our NOTICE file (its not getting picked up by the `ApacheNoticeResourceTransformer`), but as far as I can tell Flink itself is also excluding the contents completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services