You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/07/02 21:28:51 UTC
Re: More custom keywords
Julian Foad <ju...@btopenworld.com> writes:
> Given a log message, which I could write myself if persuaded to do so,
> and a slightly more thorough review, I would suggest we accept and
> commit parts (1) (2) and (3) of this.
>
> Any other thoughts?
I haven't reviewed the patch, but the custom keywords system looks
completely sane to me (and even intuitive, for a certain demographic
anyway). +1 to concept.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: More custom keywords
Posted by John Peacock <jo...@havurah-software.org>.
Karl Fogel wrote:
> Julian Foad <ju...@btopenworld.com> writes:
>> Given a log message, which I could write myself if persuaded to do so,
>> and a slightly more thorough review, I would suggest we accept and
>> commit parts (1) (2) and (3) of this.
>>
>> Any other thoughts?
>
> I haven't reviewed the patch, but the custom keywords system looks
> completely sane to me (and even intuitive, for a certain demographic
> anyway). +1 to concept.
Yeah, I like this design much better than my attempt to turn properties into
keywords:
http://svn.haxx.se/dev/archive-2004-04/1184.shtml
It's been so long since I was in this deep into the Subversion code, I'd hate to
offer anything more than a conditional "I've read through the patch and it looks
like it does what it says it does".
I do agree that the %H and %I syntactic sugar formats are not strictly
necessary, and the fact that they are exclusive of any other format string makes
them less useful. I would actually take them out in preference to writing out
the longer forms, but it wouldn't be terrible if they were left in (and
documented thoroughly)...
John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org