[GitHub] [incubator-iceberg] jerryshao commented on issue #678: Add Java code examples and update site docs

[GitBox <gi...@apache.org>]

jerryshao commented on issue #678: Add Java code examples and update site docs
URL: https://github.com/apache/incubator-iceberg/pull/678#issuecomment-604780100
 
 
   My two concerns about this example:
   
   1. Shall we have a common example module, or modules for each engine. My concern is that as we're adding support for different engines, we would add more examples codes for different engined, then including different dependencies could be a hard-to-solve problem.
   2. I'm not so sure about the advantages of using UTs to show the examples. It seems to me a little strange. Yes, this is easy to debug and modify, but not easy to run on a real cluster by `spark-submit`, which also gives the user the impression of UTs rather than real examples. I don't have a strong objection on this, just a little concern about the choice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org