[jira] Commented: (TUSCANY-1765) Component implementation has wrong intent

["Venkatakrishnan (JIRA)" <tu...@ws.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532395 ] 

Venkatakrishnan commented on TUSCANY-1765:
------------------------------------------

Hi.. thanks for the patch.   This does solve the problem to some extent - for the case where intents are directly attached to an implementation element.    But what about the case of intents inherited from ancestors.  For example ...

<composite xmlns="http://www.osoa.org/xmlns/sca/1.0" name="CompositeX">
    <component name="ComponentA" requires="managedTransaction.none">
        <implementation.java class="test.DataServiceImpl" />
    </component>
    <component name="ComponentB" requires="managedTransaction.global">
        <implementation.java class="test.DataServiceImpl" r/>
    </component>
</composite> 

The computation / aggregation of intents is done after the resolution phase.  So I guess this problem will still persist for this case.  Isnt it ?

> Component implementation has wrong intent
> -----------------------------------------
>
>                 Key: TUSCANY-1765
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1765
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Assembly Model
>    Affects Versions: Java-SCA-0.99
>            Reporter: Greg Dritschler
>            Assignee: Venkatakrishnan
>            Priority: Minor
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-1765.patch
>
>
> Suppose there is a composite with multiple components that use the same implementation class but different implementation intents, as shown below.
> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0" name="CompositeX">
>     <component name="ComponentA">
>         <implementation.java class="test.DataServiceImpl" requires="managedTransaction.none"/>
>     </component>
>     <component name="ComponentB">
>         <implementation.java class="test.DataServiceImpl" requires="managedTransaction.global"/>
>     </component>
> </composite>
> In this case the components will share a common Implementation model object because only the class name is being used to determine whether a component's implementation is the same as another's.  This means one of the components will have the wrong implementation intents recorded in the model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org