You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Steve Loughran (Jira)" <ji...@apache.org> on 2022/05/30 13:08:00 UTC

[jira] [Resolved] (HADOOP-18269) Misleading method name in DistCpOptions

     [ https://issues.apache.org/jira/browse/HADOOP-18269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran resolved HADOOP-18269.
-------------------------------------
    Resolution: Fixed

> Misleading method name in DistCpOptions
> ---------------------------------------
>
>                 Key: HADOOP-18269
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18269
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: tools/distcp
>    Affects Versions: 3.3.2
>            Reporter: guophilipse
>            Assignee: guophilipse
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.3.4
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Currently method in DistCpOptions withCRC was used as the following
> ```
> withCRC(true) means check without crc
> withCRC(false) means check with crc
> ```
> which mislead the developer when we pass the paramter, we can rename the method to clear that.after that it should be:
> ```
> withSkipCRC(true) means check without crc
> withSkipCRC(false) means check with crc
> ```
> so it will be more understandable.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org