You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Pavel Zubkou (Created) (JIRA)" <ji...@apache.org> on 2012/04/18 13:33:39 UTC
[jira] [Created] (CB-538) Change onReceivedError logic to allow
scripts to handle iframe loading errors
Change onReceivedError logic to allow scripts to handle iframe loading errors
-----------------------------------------------------------------------------
Key: CB-538
URL: https://issues.apache.org/jira/browse/CB-538
Project: Apache Callback
Issue Type: Improvement
Components: Android
Affects Versions: 1.6.0
Reporter: Pavel Zubkou
Assignee: Joe Bowser
If I understand correctly, onReceivedError handles WebView loading errors, both for a document loaded into a WebView and for iframes loaded inside the document. Currently onReceivedError has actually to outcomes: load page specified via errorUrl property into WebView or show error dialog and close activity.
Both outcomes are not desired when error came from loading iframe since application loaded into the WebView loses control of all events and can not handle iframe loading error.
I think it would be more appropriate to check failingUrl and if it does not equals to this.url - just do not catch error in onReceivedError, thus allowing scripts from document loaded into WebView handle iframe loading errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-538) Change onReceivedError logic to allow
scripts to handle iframe loading errors
Posted by "Joe Bowser (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257831#comment-13257831 ]
Joe Bowser commented on CB-538:
-------------------------------
See CB-132
> Change onReceivedError logic to allow scripts to handle iframe loading errors
> -----------------------------------------------------------------------------
>
> Key: CB-538
> URL: https://issues.apache.org/jira/browse/CB-538
> Project: Apache Callback
> Issue Type: Improvement
> Components: Android
> Affects Versions: 1.6.0
> Reporter: Pavel Zubkou
> Assignee: Joe Bowser
>
> If I understand correctly, onReceivedError handles WebView loading errors, both for a document loaded into a WebView and for iframes loaded inside the document. Currently onReceivedError has actually to outcomes: load page specified via errorUrl property into WebView or show error dialog and close activity.
> Both outcomes are not desired when error came from loading iframe since application loaded into the WebView loses control of all events and can not handle iframe loading error.
> I think it would be more appropriate to check failingUrl and if it does not equals to this.url - just do not catch error in onReceivedError, thus allowing scripts from document loaded into WebView handle iframe loading errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CB-538) Change onReceivedError logic to allow
scripts to handle iframe loading errors
Posted by "Pavel Zubkou (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Zubkou reopened CB-538:
-----------------------------
What you mean by saying that iframes are broken? They loading a document, behave as expected and WebView calls appropriate error handlers, we just need proper handling of these errors. Please correct me, I do not understand the issue with iframes.
> Change onReceivedError logic to allow scripts to handle iframe loading errors
> -----------------------------------------------------------------------------
>
> Key: CB-538
> URL: https://issues.apache.org/jira/browse/CB-538
> Project: Apache Callback
> Issue Type: Improvement
> Components: Android
> Affects Versions: 1.6.0
> Reporter: Pavel Zubkou
> Assignee: Joe Bowser
>
> If I understand correctly, onReceivedError handles WebView loading errors, both for a document loaded into a WebView and for iframes loaded inside the document. Currently onReceivedError has actually to outcomes: load page specified via errorUrl property into WebView or show error dialog and close activity.
> Both outcomes are not desired when error came from loading iframe since application loaded into the WebView loses control of all events and can not handle iframe loading error.
> I think it would be more appropriate to check failingUrl and if it does not equals to this.url - just do not catch error in onReceivedError, thus allowing scripts from document loaded into WebView handle iframe loading errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-538) Change onReceivedError logic to allow
scripts to handle iframe loading errors
Posted by "Joe Bowser (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser resolved CB-538.
---------------------------
Resolution: Won't Fix
There are outstanding issues with loading documents in an iFrame where it instead loads it in the WebView. Those should be resolved before we look how onReceivedError works.
> Change onReceivedError logic to allow scripts to handle iframe loading errors
> -----------------------------------------------------------------------------
>
> Key: CB-538
> URL: https://issues.apache.org/jira/browse/CB-538
> Project: Apache Callback
> Issue Type: Improvement
> Components: Android
> Affects Versions: 1.6.0
> Reporter: Pavel Zubkou
> Assignee: Joe Bowser
>
> If I understand correctly, onReceivedError handles WebView loading errors, both for a document loaded into a WebView and for iframes loaded inside the document. Currently onReceivedError has actually to outcomes: load page specified via errorUrl property into WebView or show error dialog and close activity.
> Both outcomes are not desired when error came from loading iframe since application loaded into the WebView loses control of all events and can not handle iframe loading error.
> I think it would be more appropriate to check failingUrl and if it does not equals to this.url - just do not catch error in onReceivedError, thus allowing scripts from document loaded into WebView handle iframe loading errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-538) Change onReceivedError logic to allow
scripts to handle iframe loading errors
Posted by "Joe Bowser (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser resolved CB-538.
---------------------------
Resolution: Invalid
Currently iframes are broken, so we should fix iframes, not modify onReceivedError to work with broken iframes.
> Change onReceivedError logic to allow scripts to handle iframe loading errors
> -----------------------------------------------------------------------------
>
> Key: CB-538
> URL: https://issues.apache.org/jira/browse/CB-538
> Project: Apache Callback
> Issue Type: Improvement
> Components: Android
> Affects Versions: 1.6.0
> Reporter: Pavel Zubkou
> Assignee: Joe Bowser
>
> If I understand correctly, onReceivedError handles WebView loading errors, both for a document loaded into a WebView and for iframes loaded inside the document. Currently onReceivedError has actually to outcomes: load page specified via errorUrl property into WebView or show error dialog and close activity.
> Both outcomes are not desired when error came from loading iframe since application loaded into the WebView loses control of all events and can not handle iframe loading error.
> I think it would be more appropriate to check failingUrl and if it does not equals to this.url - just do not catch error in onReceivedError, thus allowing scripts from document loaded into WebView handle iframe loading errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira