[jira] [Created] (MYFACES-4543) Flash Does Not Work with Client Window URL Mode (Enabled by Default for Flows)

["Volodymyr Siedlecki (Jira)" <de...@myfaces.apache.org>]

Volodymyr Siedlecki created MYFACES-4543:
--------------------------------------------

             Summary: Flash Does Not Work with Client Window URL Mode (Enabled by Default for Flows)
                 Key: MYFACES-4543
                 URL: https://issues.apache.org/jira/browse/MYFACES-4543
             Project: MyFaces Core
          Issue Type: Bug
    Affects Versions: 3.0.2, 2.3-next-M7, 2.3.10, 2.2.10, 4.0.0-RC3
            Reporter: Volodymyr Siedlecki


This bug was discovered in the faces23/TCK

ee.jakarta.tck.faces.test.javaee8.cdi.Spec1385IT - testInjectFlash.

In a nutshell, setting an attribute on the flash map and then reloading the page does not work.  This is due to to the fact that the application also contains flows.  Flows, by default, require client window mode is set to URL, and the Flash defaults to use the client window id to track the flash tokens.

[https://github.com/apache/myfaces/blob/18f1f90cd2bdb22330444f77ff5e98097ed84634/impl/src/main/java/org/apache/myfaces/context/flash/FlashImpl.java#L752-L753]

[https://github.com/apache/myfaces/blob/18f1f90cd2bdb22330444f77ff5e98097ed84634/impl/src/main/java/org/apache/myfaces/context/flash/FlashImpl.java#L797-L798]

We could just remove the clientwindow checks (and use flash cookies as in MyFaces 2.0) , but I think it might be better to check if the current configuration requires client window url mode. If so, just use flash cookies instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)