You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/03 10:44:16 UTC

[GitHub] [rocketmq] XiaoyiPeng opened a new issue #3924: It may be better to change the method StoreStatsService#initPutMessageDistributeTime() to private

XiaoyiPeng opened a new issue #3924:
URL: https://github.com/apache/rocketmq/issues/3924


   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   ![image](https://user-images.githubusercontent.com/8653312/156546032-c82ac422-ef1f-43e4-b5e3-2d6a550e8448.png)
   
   - The method `StoreStatsService#initPutMessageDistributeTime()`  is only called in the constructor and method `StoreStatsService#printTps()`(which is **private**),  it may be better to change it to **private**.
   
       And the method `StoreStatsService#initPutMessageTimeBuckets()` also like this.
   
   - The method `StoreStatsService#initPutMessageDistributeTime()` is repeated called by method `printTps() ` periodically,
     it's internal logic is to reset the current data structure(eg:  `StoreStatsService#putMessageDistributeTime`) for new data. 
   I think it would be more appropriate for the method name to start with **reset** instead of **init**.
   
   
   2. Please tell us about your environment:
   
     - OS: Windows10
   
     -    branch: develop 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] yuz10 closed issue #3924: It may be better to change the method StoreStatsService#initPutMessageDistributeTime() to private

Posted by GitBox <gi...@apache.org>.

yuz10 closed issue #3924:
URL: https://github.com/apache/rocketmq/issues/3924


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org