You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/10 21:21:02 UTC
[GitHub] [tvm] mbs-octoml opened a new pull request, #11674: [Relay] Finish implementations of WithFields
mbs-octoml opened a new pull request, #11674:
URL: https://github.com/apache/tvm/pull/11674
This has been sitting in my collage branch forever, might as well clear it into main.
I added the beginnings of a unit test, but only for the Call overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on a diff in pull request #11674: [Relay] Finish implementations of WithFields
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on code in PR #11674:
URL: https://github.com/apache/tvm/pull/11674#discussion_r895038259
##########
src/relay/ir/expr.cc:
##########
@@ -27,6 +27,26 @@
namespace tvm {
+GlobalVar WithFields(GlobalVar global_var, Optional<String> opt_name_hint, Optional<Type> opt_type,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on pull request #11674: [Relay] Finish implementations of WithFields
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on PR #11674:
URL: https://github.com/apache/tvm/pull/11674#issuecomment-1152951996
Looks like #11631 and #11513 clashed, so I'm going to include the trivial fix as a rider in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a diff in pull request #11674: [Relay] Finish implementations of WithFields
Posted by GitBox <gi...@apache.org>.
Mousius commented on code in PR #11674:
URL: https://github.com/apache/tvm/pull/11674#discussion_r895012749
##########
src/relay/ir/expr.cc:
##########
@@ -27,6 +27,26 @@
namespace tvm {
+GlobalVar WithFields(GlobalVar global_var, Optional<String> opt_name_hint, Optional<Type> opt_type,
Review Comment:
Could you add some tests for `GlobalVar` and `Constant` variants of `WithFields`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on pull request #11674: [Relay] Finish implementations of WithFields
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on PR #11674:
URL: https://github.com/apache/tvm/pull/11674#issuecomment-1152952262
Thanks @Mousius, pls merge when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius merged pull request #11674: [Relay] Finish implementations of WithFields
Posted by GitBox <gi...@apache.org>.
Mousius merged PR #11674:
URL: https://github.com/apache/tvm/pull/11674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org