You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/16 12:41:21 UTC

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 11:41 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
-------

Change the allocation interval to 500 ms.


Summary (updated)
-----------------

Speed up FetcherCache test cases by reduce allocation_interval.


Bugs: MESOS-4618
    https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description
-------

Speed up FetcherCache test cases by advance allocation_interval.


Diffs (updated)
-----

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing (updated)
-------

Before this patch:
```
[       OK ] FetcherCacheTest.LocalUncached (1065 ms)
[       OK ] FetcherCacheTest.LocalCached (1728 ms)
[       OK ] FetcherCacheTest.CachedFallback (1105 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[       OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```

After this patch:
```
[       OK ] FetcherCacheTest.LocalUncached (984 ms)
[       OK ] FetcherCacheTest.LocalCached (1750 ms)
[       OK ] FetcherCacheTest.CachedFallback (1043 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
[       OK ] FetcherCacheTest.SimpleEviction (2723 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
```


Thanks,

haosdent huang


Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119303
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42696, 43316, 43367]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 11:42 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 11:42 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4628
>     https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up FetcherCache test cases by advance allocation_interval.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> -------
> 
> Before this patch:
> ```
> [       OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [       OK ] FetcherCacheTest.LocalCached (1728 ms)
> [       OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [       OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [       OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [       OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
> 
> After this patch:
> ```
> [       OK ] FetcherCacheTest.LocalUncached (984 ms)
> [       OK ] FetcherCacheTest.LocalCached (1750 ms)
> [       OK ] FetcherCacheTest.CachedFallback (1043 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
> [       OK ] FetcherCacheTest.SimpleEviction (2723 ms)
> [       OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
> [       OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
> [       OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 5:58 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
-------

Rebase


Summary (updated)
-----------------

Speed up FetcherCache test cases by reduce allocation_interval.


Bugs: MESOS-4628
    https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description (updated)
-------

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-----

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
-------

Before
```
[       OK ] FetcherCacheTest.LocalUncached (943 ms)
[       OK ] FetcherCacheTest.LocalCached (1612 ms)
[       OK ] FetcherCacheTest.CachedFallback (906 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[       OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[       OK ] FetcherCacheTest.LocalUncached (979 ms)
[       OK ] FetcherCacheTest.LocalCached (1510 ms)
[       OK ] FetcherCacheTest.CachedFallback (853 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[       OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang


Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 5:55 p.m.)


Review request for mesos and Bernd Mathiske.


Summary (updated)
-----------------

Speed up FetcherCache test cases by advance allocation_interval.


Bugs: MESOS-4628
    https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
-------

Speed up FetcherCache test cases by advance allocation_interval.


Diffs (updated)
-----

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing (updated)
-------

Before
```
[       OK ] FetcherCacheTest.LocalUncached (943 ms)
[       OK ] FetcherCacheTest.LocalCached (1612 ms)
[       OK ] FetcherCacheTest.CachedFallback (906 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[       OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[       OK ] FetcherCacheTest.LocalUncached (979 ms)
[       OK ] FetcherCacheTest.LocalCached (1510 ms)
[       OK ] FetcherCacheTest.CachedFallback (853 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[       OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang


Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 11:42 a.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4628
    https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
-------

Speed up FetcherCache test cases by advance allocation_interval.


Diffs
-----

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
-------

Before this patch:
```
[       OK ] FetcherCacheTest.LocalUncached (1065 ms)
[       OK ] FetcherCacheTest.LocalCached (1728 ms)
[       OK ] FetcherCacheTest.CachedFallback (1105 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[       OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```

After this patch:
```
[       OK ] FetcherCacheTest.LocalUncached (984 ms)
[       OK ] FetcherCacheTest.LocalCached (1750 ms)
[       OK ] FetcherCacheTest.CachedFallback (1043 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
[       OK ] FetcherCacheTest.SimpleEviction (2723 ms)
[       OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
[       OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
[       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
[       OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
```


Thanks,

haosdent huang