You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by satishd <gi...@git.apache.org> on 2016/04/01 13:31:29 UTC
[GitHub] storm pull request: STORM-1670 version store should consider only ...
GitHub user satishd opened a pull request:
https://github.com/apache/storm/pull/1297
STORM-1670 version store should consider only active/finished version files and avoid throwing FNF Exception
LocalState#get(String) can throw FileNotFoundException which may result in supervisr.clj#sync-processes which stop assigning new workers/assignments etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/satishd/storm STORM-1670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1297
----
commit e6a4d0f0c63bd4dfa13d9bc2016ceccff1ab4c7f
Author: Satish Duggana <sd...@hortonworks.com>
Date: 2016-04-01T10:59:53Z
STORM-1670 version store should consider ony active/finished version files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1297#issuecomment-204610812
@satishd For some reason this is causing the storm-core clojure tests to fail consistently. Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1297#issuecomment-204610269
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by satishd <gi...@git.apache.org>.
Github user satishd closed the pull request at:
https://github.com/apache/storm/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1297#issuecomment-204491215
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1297#issuecomment-204639723
@ptgoetz Tests in `org.apache.storm.versioned-store-test` does not really create a file with the created version but invoked `succeedVersion` which internally creates a `<version-path>.VERSION`. Those tests should have created a file with whatever data that wants to be saved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by satishd <gi...@git.apache.org>.
GitHub user satishd reopened a pull request:
https://github.com/apache/storm/pull/1297
STORM-1670 LocalState#get(String) can throw FileNotFoundException which may result supervisor.clj#sync-processes stop assigning new workers/assignments
LocalState#get(String) can throw FileNotFoundException which may result supervisor.clj#sync-processes stop assigning new workers/assignments etc and supervisor goes down later.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/satishd/storm STORM-1670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1297
----
commit 97849453def8258e79697622e4bde6c5596b481f
Author: Satish Duggana <sd...@hortonworks.com>
Date: 2016-04-01T10:59:53Z
STORM-1670 version store should consider ony active/finished version files
commit 3ca763e6c8082893b6ceec5227e22d0601dfcde6
Author: Satish Duggana <sd...@hortonworks.com>
Date: 2016-04-01T19:00:08Z
STORM-1670 Removed DirectoryStream changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1297#issuecomment-205493715
+1 (again). Confirmed this fixes the test failures on 1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1670 LocalState#get(String) can throw Fi...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1297#issuecomment-204547903
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---