[GitHub] [spark] Ngone51 commented on a change in pull request #31839: [SPARK-34087][SQL] Fix memory leak of ExecutionListenerBus

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #31839:
URL: https://github.com/apache/spark/pull/31839#discussion_r594396949



##########
File path: core/src/main/scala/org/apache/spark/ContextCleaner.scala
##########
@@ -293,4 +314,5 @@ private[spark] trait CleanerListener {
   def broadcastCleaned(broadcastId: Long): Unit
   def accumCleaned(accId: Long): Unit
   def checkpointCleaned(rddId: Long): Unit
+  def listenerCleaned(listener: SparkListener): Unit

Review comment:
       The session id doesn't have a 1:1 relationship with the listener so I don't think we should use the session id.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org