You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/21 06:21:36 UTC
[GitHub] [airflow] turbaszek opened a new pull request #10439: Mount gcloud kubeconifg to breeze
turbaszek opened a new pull request #10439:
URL: https://github.com/apache/airflow/pull/10439
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #10439: Mount gcloud kubeconifg to breeze
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #10439:
URL: https://github.com/apache/airflow/pull/10439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10439: Mount gcloud kubeconifg to breeze
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10439:
URL: https://github.com/apache/airflow/pull/10439#discussion_r474445153
##########
File path: backport_packages/setup_backport_packages.py
##########
@@ -215,7 +215,7 @@ def get_long_description(provider_package_id: str) -> str:
:return: content of the description (README file)
"""
package_folder = get_target_providers_package_folder(provider_package_id)
- with open(os.path.join(package_folder, "README.md"), encoding='utf-8') as file:
+ with open(os.path.join(package_folder, "README.md"), encoding='utf-8', mode="w+") as file:
Review comment:
Yeah, I will split this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10439: Mount gcloud kubeconifg to breeze
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10439:
URL: https://github.com/apache/airflow/pull/10439#discussion_r474811192
##########
File path: scripts/ci/docker-compose/forward-credentials.yml
##########
@@ -29,3 +29,4 @@ services:
- ${HOME}/.azure:/root/.azure:cached
- ${HOME}/.config:/root/.config:cached
- ${HOME}/.docker:/root/.docker:cached
+ - ${HOME}/.kube:/root/.kube:cached
Review comment:
```suggestion
```
I think we should remove this just for security reasons
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10439: Mount gcloud kubeconifg to breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10439:
URL: https://github.com/apache/airflow/pull/10439#issuecomment-678434145
Nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10439: Mount gcloud kubeconifg to breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10439:
URL: https://github.com/apache/airflow/pull/10439#discussion_r474444079
##########
File path: backport_packages/setup_backport_packages.py
##########
@@ -215,7 +215,7 @@ def get_long_description(provider_package_id: str) -> str:
:return: content of the description (README file)
"""
package_folder = get_target_providers_package_folder(provider_package_id)
- with open(os.path.join(package_folder, "README.md"), encoding='utf-8') as file:
+ with open(os.path.join(package_folder, "README.md"), encoding='utf-8', mode="w+") as file:
Review comment:
Unrelated? Separate PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org