You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2025/10/08 09:51:05 UTC
[kudu-CR] KUDU-3478: Extract functions for example tests
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23508
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
KUDU-3478: Extract functions for example tests
This patch extracts the common cluster startup, shutdown, and utility
functions from client_examples-test.sh into a new shared script
build-support/test-cluster-common.sh.
The client_examples-test.sh script is refactored to use these shared
functions.
This shared library will be reused by Python and Java example test
scripts in subsequent patches.
Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
---
A build-support/test-cluster-common.sh
M src/kudu/client/client_examples-test.sh
2 files changed, 196 insertions(+), 135 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/23508/1
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-3478: Extract functions for example tests
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23508 )
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1956/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Oct 2025 12:47:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3478: Extract functions for example tests
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23508 )
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
Patch Set 1: Code-Review+1
Looks good.
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Oct 2025 13:08:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3478: Extract functions for example tests
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23508 )
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
Patch Set 1: Verified+1
unrelated test failures:
TSAN: org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Oct 2025 17:21:52 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3478: Extract functions for example tests
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23508 )
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Oct 2025 14:20:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3478: Extract functions for example tests
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] KUDU-3478: Extract functions for example tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23508 )
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Oct 2025 03:09:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3478: Extract functions for example tests
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23508 )
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1956/
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Oct 2025 09:51:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3478: Extract functions for example tests
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23508 )
Change subject: KUDU-3478: Extract functions for example tests
......................................................................
KUDU-3478: Extract functions for example tests
This patch extracts the common cluster startup, shutdown, and utility
functions from client_examples-test.sh into a new shared script
build-support/test-cluster-common.sh.
The client_examples-test.sh script is refactored to use these shared
functions.
This shared library will be reused by Python and Java example test
scripts in subsequent patches.
Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Reviewed-on: http://gerrit.cloudera.org:8080/23508
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
A build-support/test-cluster-common.sh
M src/kudu/client/client_examples-test.sh
2 files changed, 196 insertions(+), 135 deletions(-)
Approvals:
Zoltan Martonka: Looks good to me, but someone else must approve
Gabriella Lotz: Looks good to me, but someone else must approve
Marton Greber: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2dfb6c51bbbbb882b8f42412a651d63a2a51a0b
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>