You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Pablo Estrada (Jira)" <ji...@apache.org> on 2021/09/28 23:24:00 UTC
[jira] [Updated] (BEAM-9058) Line-too-long Python lint checks are
no longer working.
[ https://issues.apache.org/jira/browse/BEAM-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pablo Estrada updated BEAM-9058:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Open)
> Line-too-long Python lint checks are no longer working.
> -------------------------------------------------------
>
> Key: BEAM-9058
> URL: https://issues.apache.org/jira/browse/BEAM-9058
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: P3
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Without getting into a question whether 80 is a reasonable limit, what are the reasons to treat type annotations differently than other parts of Python code (including comments), which have a 80 character limit?
>
> Places that need to be fixed (PR coming):
> ```
> {noformat}
> > Task :sdks:python:test-suites:tox:py37:lintPy37
>
> ************* Module apache_beam.testing.test_stream_it_test
> apache_beam/testing/test_stream_it_test.py:50:0: C0301: Line too long (106/80) (line-too-long)
> ************* Module apache_beam.io.filesystems
> apache_beam/io/filesystems.py:99:0: C0301: Line too long (101/80) (line-too-long)
> apache_beam/io/filesystems.py:100:0: C0301: Line too long (111/80) (line-too-long)
> ************* Module apache_beam.runners.portability.fn_api_runner
> apache_beam/runners/portability/fn_api_runner.py:115:0: C0301: Line too long (114/80) (line-too-long)
> ************* Module apache_beam.transforms.core
> apache_beam/transforms/core.py:1307:0: C0301: Line too long (116/80) (line-too-long)
> apache_beam/transforms/core.py:2271:0: C0301: Line too long (95/80) (line-too-long)
> apache_beam/transforms/core.py:2272:0: C0301: Line too long (90/80) (line-too-long)
> ************* Module setup
> setup.py:141:0: C0301: Line too long (81/80) (line-too-long)
> ------------------------------------
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)