You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ch...@apache.org on 2018/05/11 22:24:44 UTC

mesos git commit: Made `UriDiskProfileAdaptor` be able to update profile selectors.

Repository: mesos
Updated Branches:
  refs/heads/master d0de83382 -> 5e740063d


Made `UriDiskProfileAdaptor` be able to update profile selectors.

Review: https://reviews.apache.org/r/67078


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/5e740063
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/5e740063
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/5e740063

Branch: refs/heads/master
Commit: 5e740063d433b8f2b89ca43a4d3e93dfbdeb6d8f
Parents: d0de833
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Authored: Thu May 10 20:27:24 2018 -0700
Committer: Chun-Hung Hsiao <ch...@mesosphere.io>
Committed: Fri May 11 14:34:26 2018 -0700

----------------------------------------------------------------------
 src/resource_provider/storage/uri_disk_profile_adaptor.cpp | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/5e740063/src/resource_provider/storage/uri_disk_profile_adaptor.cpp
----------------------------------------------------------------------
diff --git a/src/resource_provider/storage/uri_disk_profile_adaptor.cpp b/src/resource_provider/storage/uri_disk_profile_adaptor.cpp
index 300ea12..614590e 100644
--- a/src/resource_provider/storage/uri_disk_profile_adaptor.cpp
+++ b/src/resource_provider/storage/uri_disk_profile_adaptor.cpp
@@ -278,11 +278,8 @@ void UriDiskProfileAdaptorProcess::notify(
     return;
   }
 
-  // Profiles can only be added, so if the parsed data is the same size,
-  // nothing has changed and no notifications need to be sent.
-  if (parsed.profile_matrix().size() <= profileMatrix.size()) {
-    return;
-  }
+  // TODO(chhsiao): No need to update the profile matrix and send notifications
+  // if the parsed mapping has the same size and profile selectors.
 
   // The fetched mapping satisfies our invariants.