Re: cvs commit: apr/misc/win32 rand.c

[David Shane Holden <dp...@yahoo.com>]

Ya forgot to remove the unnecessary header files in rand.c 'cause that's 
where the problem lies.

Shane


wrowe@apache.org wrote:

>wrowe       2002/07/17 13:19:35
>
>  Modified:    .        libapr.dsp
>               misc/win32 rand.c
>  Log:
>    Skip the entire CoAPI garbage and go right for UuidCreate(), which on
>    Win2000/XP no longer reveals the mac address.
>  
>  Submitted by:	David Shane Holden <dp...@yahoo.com>
>   
>  
>  
>  
>  1.16      +5 -2      apr/misc/win32/rand.c
>  
>  Index: rand.c
>  ===================================================================
>  RCS file: /home/cvs/apr/misc/win32/rand.c,v
>  retrieving revision 1.15
>  retrieving revision 1.16
>  diff -u -r1.15 -r1.16
>  --- rand.c	17 Jul 2002 04:11:33 -0000	1.15
>  +++ rand.c	17 Jul 2002 20:19:35 -0000	1.16
>  @@ -93,9 +93,12 @@
>        * possible misuse/abuse since uuid is based on the NIC address, and
>        * is therefore not only a uniqifier, but an identity (which might not
>        * be appropriate in all cases.
>  +     *
>  +     * Note that Win2000, XP and later no longer suffer from this problem,
>  +     * a scrambling fix is only needed for (apr_os_level < APR_WIN_2000)
>        */
>  -    if (FAILED(CoCreateGuid((LPGUID)uuid_data))) {
>  -	return APR_EGENERAL;
>  +    if (FAILED(UuidCreate((UUID *)uuid_data))) {
>  +        return APR_EGENERAL;
>       }
>       return APR_SUCCESS;
>   }
>  
>  
>  
>
>  
>

Re: cvs commit: apr/misc/win32 rand.c

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

At 03:32 PM 7/17/2002, David Shane Holden wrote:
>Ya forgot to remove the unnecessary header files in rand.c 'cause that's 
>where the problem lies.

Outch, yes.  Fixed