You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2023/05/21 23:20:31 UTC

[Bug 66609] New: invalid XML in directory listing with file names containing "&" and "'"

https://bz.apache.org/bugzilla/show_bug.cgi?id=66609

            Bug ID: 66609
           Summary: invalid XML in directory listing with file names
                    containing "&" and "'"
           Product: Tomcat 8
           Version: 8.5.x-trunk
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: alexkachanov@yandex.ru
  Target Milestone: ----

similar to bug 33535: if files in a directroy contain "'" or "&" symbols,
generted XML is not valid and XSLT style sheet cannot be applied to render the
directory listing. 

Cause: DefaultServelt considers "'" as a valid character on URLEncoder.DEFAULT,
renderXML surronds attributes with ' symbol, and thus XML generated by
renderXML may contain invalid entry with url attribute like this <entry
urlPath='file's name.txt' />

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 66609] invalid XML in directory listing with file names containing "&" and "'"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609

--- Comment #4 from webmascon <al...@yandex.ru> ---
created pull request: https://github.com/apache/tomcat/pull/621

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 66609] invalid XML in directory listing with file names containing "&" and "'"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609

Han Li <li...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|DUPLICATE                   |FIXED

--- Comment #5 from Han Li <li...@apache.org> ---
Fixed in:
- 11.0.x for 11.0.0-M7 onwards
- 10.1.x for 10.1.10 onwards
- 9.0.x for 9.0.76 onwards
- 8.5.x for 8.5.90 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 66609] invalid XML in directory listing with file names containing "&" and "'"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609

--- Comment #6 from webmascon <al...@yandex.ru> ---
thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 66609] invalid XML in directory listing with file names containing "&" and "'"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609

Han Li <li...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Han Li <li...@apache.org> ---


*** This bug has been marked as a duplicate of bug 33535 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 66609] invalid XML in directory listing with file names containing "&" and "'"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609

--- Comment #2 from webmascon <al...@yandex.ru> ---
The bug may be similar to bug 33535, but bug 33535 says only about & in the
names of the files. My bug report says that there are can be symbols that are
not valid for XML, such as symbol "'". And I have a simple solution to that
which I was goign to provide as a fix for this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 66609] invalid XML in directory listing with file names containing "&" and "'"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609

--- Comment #3 from Han Li <li...@apache.org> ---
(In reply to webmascon from comment #2)
> The bug may be similar to bug 33535, but bug 33535 says only about & in the
> names of the files. My bug report says that there are can be symbols that
> are not valid for XML, such as symbol "'". 
IMO, Those reports are all about handling file names that contain special
characters which lead XML is invalided.

> And I have a simple solution to that which I was goign to provide as a fix for this bug.

Great.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org