You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/04 02:10:52 UTC

[GitHub] [skywalking] kezhenxu94 opened a new issue, #9301: [Python] add docs about how to run tests locally (or even simplify it if it's too complex)

kezhenxu94 opened a new issue, #9301:
URL: https://github.com/apache/skywalking/issues/9301

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Related to https://github.com/apache/skywalking-python/pull/214#pullrequestreview-1026894959 .
   
   Our contributor has to look around the repo for demo scripts to run the tests locally. Sometimes they have to try over and over. I'd expect the guide to run tests locally should be clearly documented step by step.
   
   We should add a new section in https://github.com/apache/skywalking-python/blob/master/docs/en/contribution/PluginTest.md
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] kezhenxu94 closed issue #9301: [Python] add docs about how to run tests locally (or even simplify it if it's too complex)

Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #9301: [Python] add docs about how to run tests locally (or even simplify it if it's too complex)
URL: https://github.com/apache/skywalking/issues/9301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng commented on issue #9301: [Python] add docs about how to run tests locally (or even simplify it if it's too complex)

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9301:
URL: https://github.com/apache/skywalking/issues/9301#issuecomment-1180185958

   You could send a pull request directly. It is fine if more polish could be done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] kezhenxu94 commented on issue #9301: [Python] add docs about how to run tests locally (or even simplify it if it's too complex)

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #9301:
URL: https://github.com/apache/skywalking/issues/9301#issuecomment-1180198738

   > I write a guide to local test in this [commit](https://github.com/jiang1997/skywalking-python/commit/acc9f08f01edba66991907d8a6b428777371f199). Do you have any suggestions for this before I pull request.
   
   Feel free to just open a pull request. You don't have to make it perfect before opening a pull request. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] jiang1997 commented on issue #9301: [Python] add docs about how to run tests locally (or even simplify it if it's too complex)

Posted by GitBox <gi...@apache.org>.
jiang1997 commented on issue #9301:
URL: https://github.com/apache/skywalking/issues/9301#issuecomment-1180168891

   I write a guide to local test in this [commit](https://github.com/jiang1997/skywalking-python/commit/acc9f08f01edba66991907d8a6b428777371f199). Do you have any suggestions for this before I pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] jiang1997 commented on issue #9301: [Python] add docs about how to run tests locally (or even simplify it if it's too complex)

Posted by GitBox <gi...@apache.org>.
jiang1997 commented on issue #9301:
URL: https://github.com/apache/skywalking/issues/9301#issuecomment-1180282679

   Got it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] kezhenxu94 commented on issue #9301: [Python] add docs about how to run tests locally (or even simplify it if it's too complex)

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #9301:
URL: https://github.com/apache/skywalking/issues/9301#issuecomment-1181222444

   Closed by apache/skywalking-python#222


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org