You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by udoklein <gi...@git.apache.org> on 2016/01/07 10:57:20 UTC
[GitHub] spark pull request: removed redundant variable numVertices from tr...
GitHub user udoklein opened a pull request:
https://github.com/apache/spark/pull/10642
removed redundant variable numVertices from transitive closure example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/udoklein/spark patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10642
----
commit 92096e2049b058d12f49cd47270a404592bcc460
Author: Udo Klein <gi...@blinkenlight.net>
Date: 2016-01-07T09:57:08Z
removed redundant variable numVertices from transitive closure example
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10642#discussion_r49175009
--- Diff: examples/src/main/python/transitive_closure.py ---
@@ -23,7 +23,6 @@
from pyspark import SparkContext
numEdges = 200
-numVertices = 100
--- End diff --
OK if you update this I'll merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fixed numVertices in transitive closure exampl...
Posted by udoklein <gi...@git.apache.org>.
Github user udoklein commented on the pull request:
https://github.com/apache/spark/pull/10642#issuecomment-170113590
@srowen Better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fixed numVertices in transitive closure exampl...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10642#issuecomment-170115954
Merged to master/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by udoklein <gi...@git.apache.org>.
Github user udoklein closed the pull request at:
https://github.com/apache/spark/pull/10642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10642#issuecomment-169617955
I agree, though this is virtually too trivial to bother with
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10642#issuecomment-169615027
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by udoklein <gi...@git.apache.org>.
Github user udoklein commented on a diff in the pull request:
https://github.com/apache/spark/pull/10642#discussion_r49123174
--- Diff: examples/src/main/python/transitive_closure.py ---
@@ -23,7 +23,6 @@
from pyspark import SparkContext
numEdges = 200
-numVertices = 100
--- End diff --
Yes, you are right, the bug is in the rand.randrange part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10642#issuecomment-170112128
@udoklein last little thing, can you update the title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10642#issuecomment-170106925
**[Test build #2353 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2353/consoleFull)** for PR 10642 at commit [`1ddc86f`](https://github.com/apache/spark/commit/1ddc86fedec934f3b3af7e5b56cba9b0bdcd563e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fixed numVertices in transitive closure exampl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10642#issuecomment-170111139
**[Test build #2353 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2353/consoleFull)** for PR 10642 at commit [`1ddc86f`](https://github.com/apache/spark/commit/1ddc86fedec934f3b3af7e5b56cba9b0bdcd563e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10642#discussion_r49071610
--- Diff: examples/src/main/python/transitive_closure.py ---
@@ -23,7 +23,6 @@
from pyspark import SparkContext
numEdges = 200
-numVertices = 100
--- End diff --
Wait, actually isn't the bug below? `rand.randrange(0, numEdges)` should be `rand.randrange(0, numVertices)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by udoklein <gi...@git.apache.org>.
Github user udoklein commented on the pull request:
https://github.com/apache/spark/pull/10642#issuecomment-170105923
Fixed it as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: removed redundant variable numVertices from tr...
Posted by udoklein <gi...@git.apache.org>.
GitHub user udoklein reopened a pull request:
https://github.com/apache/spark/pull/10642
removed redundant variable numVertices from transitive closure example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/udoklein/spark patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10642
----
commit 92096e2049b058d12f49cd47270a404592bcc460
Author: Udo Klein <gi...@blinkenlight.net>
Date: 2016-01-07T09:57:08Z
removed redundant variable numVertices from transitive closure example
commit 1ddc86fedec934f3b3af7e5b56cba9b0bdcd563e
Author: Udo Klein <gi...@blinkenlight.net>
Date: 2016-01-08T19:50:53Z
fixed numVertices the right way
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org