You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/08/09 10:16:49 UTC
[GitHub] [spark] itholic opened a new pull request, #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
itholic opened a new pull request, #42410:
URL: https://github.com/apache/spark/pull/42410
### What changes were proposed in this pull request?
This is follow-up for https://github.com/apache/spark/pull/41877 to remove JVM dependency.
### Why are the changes needed?
To remove JVM dependency from Pandas API on Spark with Spark Connect.
### Does this PR introduce _any_ user-facing change?
No, it's internal handling.
### How was this patch tested?
The existing UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
URL: https://github.com/apache/spark/pull/42410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #42410:
URL: https://github.com/apache/spark/pull/42410#issuecomment-1671053832
cc @HyukjinKwon addressing https://github.com/apache/spark/pull/41877/files#r1286739868.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42410:
URL: https://github.com/apache/spark/pull/42410#issuecomment-1671157940
Oops, I didn't see the tests are still running. Reverting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42410:
URL: https://github.com/apache/spark/pull/42410#issuecomment-1671156614
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #42410:
URL: https://github.com/apache/spark/pull/42410#issuecomment-1672877954
CI passed. @HyukjinKwon FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
URL: https://github.com/apache/spark/pull/42410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42410:
URL: https://github.com/apache/spark/pull/42410#issuecomment-1671159407
@itholic please fix the linter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42410: [SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42410:
URL: https://github.com/apache/spark/pull/42410#issuecomment-1672955384
LGTM, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org