You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@zookeeper.apache.org by "Erik (Jira)" <ji...@apache.org> on 2020/02/29 01:29:00 UTC
[jira] [Updated] (ZOOKEEPER-3744) Make build reproducible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik updated ZOOKEEPER-3744:
----------------------------
Description:
Maven has added built-in support for creating reproducible builds. See [https://maven.apache.org/guides/mini/guide-reproducible-builds.html.] The Zookeeper build is very close to being reproducible as is and would only require minor changes to get all the way there:
# Add the property project.build.outputTimestamp to the top level project object model.
# Upgrade the maven-jar-plugin to 3.2.0.
# Enable notimestamp for the maven-javadoc-plugin.
# Figure out what to do with the classes Version, VersionInfo and VersionInfoMain.
I did the first three and attached is the resulting diffoscope log for .\zookeeper-assembly\target\apache-zookeeper-3.7.0-SNAPSHOT-bin.tar.gz.
For 1 and 4 I suggest using a Git commit timestamp.
For 3 I believe there could be a fix in the upcoming 3.2.0 version of the maven-javadoc-plugin that would make notimestamp unnecessary. See https://issues.apache.org/jira/browse/MJAVADOC-627.
was:
Maven has added built-in support for creating reproducible builds. See [https://maven.apache.org/guides/mini/guide-reproducible-builds.html.] The Zookeeper build is very close to being reproducible as is and would only require minor changes to get all the way there:
# Add the property project.build.outputTimestamp to the top level project object model.
# Upgrade the maven-jar-plugin to 3.2.0.
# Enable notimestamp for the maven-javadoc-plugin.
# Figure out to do with the classes Version, VersionInfo and VersionInfoMain.
I did the first three and attached is the resulting diffoscope log for .\zookeeper-assembly\target\apache-zookeeper-3.7.0-SNAPSHOT-bin.tar.gz.
For 1 and 4 I suggest using a Git commit timestamp.
For 3 I believe there could be a fix in the upcoming 3.2.0 version of the maven-javadoc-plugin that would make notimestamp unnecessary. See https://issues.apache.org/jira/browse/MJAVADOC-627.
> Make build reproducible
> -----------------------
>
> Key: ZOOKEEPER-3744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3744
> Project: ZooKeeper
> Issue Type: Wish
> Reporter: Erik
> Priority: Major
> Attachments: diffoscope.txt
>
>
> Maven has added built-in support for creating reproducible builds. See [https://maven.apache.org/guides/mini/guide-reproducible-builds.html.] The Zookeeper build is very close to being reproducible as is and would only require minor changes to get all the way there:
> # Add the property project.build.outputTimestamp to the top level project object model.
> # Upgrade the maven-jar-plugin to 3.2.0.
> # Enable notimestamp for the maven-javadoc-plugin.
> # Figure out what to do with the classes Version, VersionInfo and VersionInfoMain.
> I did the first three and attached is the resulting diffoscope log for .\zookeeper-assembly\target\apache-zookeeper-3.7.0-SNAPSHOT-bin.tar.gz.
> For 1 and 4 I suggest using a Git commit timestamp.
> For 3 I believe there could be a fix in the upcoming 3.2.0 version of the maven-javadoc-plugin that would make notimestamp unnecessary. See https://issues.apache.org/jira/browse/MJAVADOC-627.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)