You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2009/10/17 02:19:31 UTC
[jira] Created: (HDFS-713) Need to properly check the type of the
test class from an aspect
Need to properly check the type of the test class from an aspect
----------------------------------------------------------------
Key: HDFS-713
URL: https://issues.apache.org/jira/browse/HDFS-713
Project: Hadoop HDFS
Issue Type: Test
Affects Versions: 0.22.0
Reporter: Konstantin Boudnik
Fix For: 0.22.0
While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-713:
------------------------------------
Attachment: HDFS-713.patch
Slightly better version of the same patch
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767478#action_12767478 ]
Konstantin Boudnik commented on HDFS-713:
-----------------------------------------
Also, have ran fault injection tests - everything works as expected:
{noformat}
[junit] Running org.apache.hadoop.hdfs.TestFiHFlush
[junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 19.173 sec
[junit] Running org.apache.hadoop.hdfs.server.datanode.TestFiDataTransferProtocol
[junit] Tests run: 16, Failures: 0, Errors: 0, Time elapsed: 207.648 sec
{noformat}
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-713:
------------------------------------
Attachment: HDFS-713.patch
Thanks, Nicholas. I've renamed the variable - it makes sense.
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-713:
------------------------------------
Status: Patch Available (was: Open)
One liner trivial fix
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767469#action_12767469 ]
Konstantin Boudnik commented on HDFS-713:
-----------------------------------------
Here's the result of test-patch run:
{noformat}
There appear to be 104 release audit warnings before the patch and 104 release audit warnings after applying the patch.
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
{noformat}
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769804#action_12769804 ]
Hudson commented on HDFS-713:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #120 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/120/])
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770278#action_12770278 ]
Hudson commented on HDFS-713:
-----------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #78 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/78/])
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-713:
------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Status: Resolved (was: Patch Available)
I have just committed it.
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767521#action_12767521 ]
Tsz Wo (Nicholas), SZE commented on HDFS-713:
---------------------------------------------
+1 patch looks good.
Some thought: since hft may not be an instanceof HFlushTest, the variable name (hft, acronym of HFlushTest) may be misleading.
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reassigned HDFS-713:
---------------------------------------
Assignee: Konstantin Boudnik
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-713:
------------------------------------
Attachment: HDFS-713.patch
Patch forces a type validation in advance
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769063#action_12769063 ]
Hudson commented on HDFS-713:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #79 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/79/])
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-713) Need to properly check the type of the
test class from an aspect
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768395#action_12768395 ]
Hudson commented on HDFS-713:
-----------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #47 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/47/])
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.