You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/26 10:49:22 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #9323: Expose more info with unknown exception

sijie commented on a change in pull request #9323:
URL: https://github.com/apache/pulsar/pull/9323#discussion_r564418491



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java
##########
@@ -117,6 +115,7 @@ public void readEntriesFailed(ManagedLedgerException exception, Object ctx) {
             if (!(exception instanceof TooManyRequestsException)) {
                 log.warn("[{}][{}] read failed from ledger at position:{} : {}", cursor.ledger.getName(),
                         cursor.getName(), readPosition, exception.getMessage());
+                log.warn("error caused by: ", exception.getCause());

Review comment:
       Why not just add the stacktrace to the previous `log.warn` statement?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org