You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/12 18:27:00 UTC

[jira] [Commented] (AIRFLOW-6541) Use EmrJobFlowSensor for other states

    [ https://issues.apache.org/jira/browse/AIRFLOW-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013833#comment-17013833 ] 

ASF GitHub Bot commented on AIRFLOW-6541:
-----------------------------------------

mustafagok commented on pull request #7146: [AIRFLOW-6541] Use EmrJobFlowSensor for other states
URL: https://github.com/apache/airflow/pull/7146
 
 
   Currently, EmrJobFlowSensor waits cluster to be terminated (state: "TERMINATED"). It can be used for other purposes if cluster states to be checked (i.e., NON_TERMINAL_STATES) can be passed to the operator.
   
   For example, this sensor could be used to wait cluster to be ready (state: "RUNNING" or "WAITING").
   
   Remove class constants of EmrBaseSensor: NON_TERMINAL_STATES, FAILED_STATE. Add new parameters: target_states and failed_states. Eliminate pylint warnings. Do not change default behaviour of the updated sensors.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use EmrJobFlowSensor for other states
> -------------------------------------
>
>                 Key: AIRFLOW-6541
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6541
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: aws, contrib
>    Affects Versions: 1.10.7
>            Reporter: Mustafa Gök
>            Assignee: Mustafa Gök
>            Priority: Minor
>
> Currently, EmrJobFlowSensor waits cluster to be terminated (state: "TERMINATED"). It can be used for other purposes if cluster states to be checked (i.e., NON_TERMINAL_STATES) can be passed to the operator.
> For example, this sensor could be used to wait cluster to be ready (state: "RUNNING" or "WAITING").



--
This message was sent by Atlassian Jira
(v8.3.4#803005)