You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Nathan Beyer (JIRA)" <ji...@apache.org> on 2006/04/22 20:21:05 UTC

[jira] Created: (HARMONY-393) [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case

[classlib][luni] Add java.lang.EnumConstantNotPresentException and test case
----------------------------------------------------------------------------

         Key: HARMONY-393
         URL: http://issues.apache.org/jira/browse/HARMONY-393
     Project: Harmony
        Type: New Feature

  Components: Classlib  
    Reporter: Nathan Beyer
    Priority: Minor


Implementation of java.lang.EnumConstantNotPresentException and test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-393) [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-393?page=all ]

Stepan Mishura reassigned HARMONY-393:
--------------------------------------

    Assign To: Stepan Mishura

> [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case
> ----------------------------------------------------------------------------
>
>          Key: HARMONY-393
>          URL: http://issues.apache.org/jira/browse/HARMONY-393
>      Project: Harmony
>         Type: New Feature

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: EnumConstantNotPresentException.java, EnumConstantNotPresentExceptionTest.java
>
> Implementation of java.lang.EnumConstantNotPresentException and test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-393) [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-393?page=all ]
     
Stepan Mishura resolved HARMONY-393:
------------------------------------

    Resolution: Fixed

Hi Nathan,

Java doesn't let constructor to return null value and the next check doesn't make sense for me:
        EnumConstantNotPresentException e = new EnumConstantNotPresentException(Fixture.class, "FOUR");
        assertNotNull(e);
So I removed this code from unit test.

Updated patch was applied to LUNI module at repo revision 396464.

Please check that the patch was applied as you expected.

> [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case
> ----------------------------------------------------------------------------
>
>          Key: HARMONY-393
>          URL: http://issues.apache.org/jira/browse/HARMONY-393
>      Project: Harmony
>         Type: New Feature

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: EnumConstantNotPresentException.java, EnumConstantNotPresentExceptionTest.java
>
> Implementation of java.lang.EnumConstantNotPresentException and test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-393) [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case

Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-393?page=comments#action_12376146 ] 

Nathan Beyer commented on HARMONY-393:
--------------------------------------

Yeah, I'm aware of the constructor dynamics. That's just how I've tested constructors in the past; the thought being being that the constructor is tested in the constructor test method and the assert is just there to assert something. It's not a big deal, I won't do it in the future.

The patch looks good, thanks.

> [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case
> ----------------------------------------------------------------------------
>
>          Key: HARMONY-393
>          URL: http://issues.apache.org/jira/browse/HARMONY-393
>      Project: Harmony
>         Type: New Feature

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: EnumConstantNotPresentException.java, EnumConstantNotPresentExceptionTest.java
>
> Implementation of java.lang.EnumConstantNotPresentException and test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-393) [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case

Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-393?page=all ]

Nathan Beyer updated HARMONY-393:
---------------------------------

    Attachment: EnumConstantNotPresentException.java
                EnumConstantNotPresentExceptionTest.java

> [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case
> ----------------------------------------------------------------------------
>
>          Key: HARMONY-393
>          URL: http://issues.apache.org/jira/browse/HARMONY-393
>      Project: Harmony
>         Type: New Feature

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Priority: Minor
>  Attachments: EnumConstantNotPresentException.java, EnumConstantNotPresentExceptionTest.java
>
> Implementation of java.lang.EnumConstantNotPresentException and test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-393) [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-393?page=all ]
     
Stepan Mishura closed HARMONY-393:
----------------------------------


Verified by Nathan.

> [classlib][luni] Add java.lang.EnumConstantNotPresentException and test case
> ----------------------------------------------------------------------------
>
>          Key: HARMONY-393
>          URL: http://issues.apache.org/jira/browse/HARMONY-393
>      Project: Harmony
>         Type: New Feature

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: EnumConstantNotPresentException.java, EnumConstantNotPresentExceptionTest.java
>
> Implementation of java.lang.EnumConstantNotPresentException and test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira